Skip to content

Conversation

@ggolin
Copy link

@ggolin ggolin commented Jul 12, 2024

Reason for this change: as reported on Slack, mordred consumes comments as part of the configured value, so folks who copy-paste configuration from the documentation run into cryptic errors, for example:

setup.cfg

[${section}]
${setting} = [item-1, item-2] # (optional)

Error:

Error while consuming configuration: Wrong type for section param: ${section} ${setting} <class 'str'> should be <class 'list'>

Removing the comment # (optional) fixes this issue.

Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me but can you add to the commit the Signed-off trailer? All contributions need to be signed: https://github.com/chaoss/grimoirelab/blob/master/CONTRIBUTING_WITH_CODE.md#developer-certificate-origin

Thanks!

@vchrombie
Copy link
Member

Hi @ggolin, do you need any help for completing this?

Let me know if it’s okay for me to take it up, as it has been a pressing issue for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants