Add cos abstraction for testing grafana-agent-k8s #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of Kubeflow enhancement to integrate observability to all charms (37). Since all tests will be the same in all charms, it makes sense to put them on one place. This help to test integration of any k8s charm and grafana-agent-k8s charm, as it was discussed with observability team this is recommended way to test such integration. Deploying whole cos should not be necessary. See the original implementation in Chisme [1]. --- [1]: canonical/charmed-kubeflow-chisme#98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of Kubeflow enhancement to integrate observability to all charms (37). Since all tests will be the same in all charms, it makes sense to put them on one place.
This help to test integration of any k8s charm and grafana-agent-k8s charm, as it was discussed with observability team this is recommended way to test such integration. Deploying whole cos should not be necessary.
See the original implementation in Chisme 1.
fixes: #134