Conversation
Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
✅ Deploy Preview for chef-infra-client ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Should these resources be deleted?
|
|
The following resources have this set of actions added, but there's no explanation of what they are:
I assume the actions are inherited from the package resource, but the description isn't being added to the YAML output by the rake task. |
|
Several resources have the default value of the
|
| @@ -37,6 +37,8 @@ properties_list: | |||
| default_value: lazy default | |||
| :purge: | ||
| markdown: Purge a gem. This action typically removes the configuration files | ||
| as well as the gem. | ||
| markdown: Purge a package. This action typically removes the configuration files |
There was a problem hiding this comment.
Should this still be gem?
| :flush_cache: | ||
| markdown: |
There was a problem hiding this comment.
No description of this action.
| description_list: | ||
| - markdown: A Hash of environment variables in the form of {'ENV_VARIABLE' => 'VALUE'} | ||
| to be set before running the command. | ||
| - property: flush_cache |
There was a problem hiding this comment.
Should these properties be deleted from the package resource:
- flush-cache
- gem_binary
- homebrew_user
- ignore_failure
- notifies
- response_file
- response_file_variable
- subscribes
| new_in: '17.0' | ||
| description_list: | ||
| - markdown: Continue running a recipe if a resource fails for any reason. (default false) | ||
| - property: notifies |
There was a problem hiding this comment.
Should the notifies property be deleted?
| :change: | ||
| markdown: |
There was a problem hiding this comment.
Is there a description for this action?
| :enable: | ||
| markdown: |
There was a problem hiding this comment.
Is there a description for this?
| :flush_cache: | ||
| markdown: |
There was a problem hiding this comment.
Is there a description for this?
| :remove: | ||
| markdown: | ||
| :makecache: | ||
| markdown: Force the creation of the repository cache. This is also done automatically | ||
| when a repository is updated. | ||
| :nothing: | ||
| shortcode: resources_common_actions_nothing.md | ||
| :add: | ||
| markdown: |
There was a problem hiding this comment.
What are the values for remove and add?
| :add: | ||
| markdown: |
There was a problem hiding this comment.
Is there a description for add?
| :mask: | ||
| markdown: | ||
| :unmask: | ||
| markdown: |
There was a problem hiding this comment.
What should these be?
| ruby_type: String | ||
| required: false | ||
| description_list: | ||
| - markdown: The type of plist to be created |
There was a problem hiding this comment.
Should this be deleted?
| and new owner assignments use the current user (when necessary). | ||
| - property: group | ||
| ruby_type: Integer, String | ||
| ruby_type: '' |
There was a problem hiding this comment.
There are a bunch of instances like this where ruby_type is changed from Integer, String to ''.
| required: false | ||
| default_value: 'true' | ||
| description_list: | ||
| - markdown: '**yum_package** resource only. Downgrade a package to satisfy |
There was a problem hiding this comment.
According to this Jira ticket, the allow_downgrade is valid on several package resources.
https://progresssoftware.atlassian.net/browse/CHEF-25659
https://github.com/search?q=repo%3Achef%2Fchef%20allow_downgrade&type=code
We have it in the following resources:
- dnf_package
- dpkg_package
- package
- rpm_package
- yum_package
- zypper_package
Description
Version
These are changes for Chef Infra Client versions:
Definition of done
Issues resolved
Related PRs
Checklist