add the possibility to load only a mesh subset

[Mateasek]

No description provided.

[jacklovell]

Please add this new argument to the end of the list. Otherwise existing codes which call this function with positional rather than keyword arguments will break.

[Mateasek]

Good point, I shifted it to the end.

[jacklovell]

I don't think mesh_description is the best name for this argument. How about mesh_components instead?

[Mateasek]

I'm not sure here. You have to pas a list of tuples containing path to the file and material. That is closer to description than components. What about component_description?

[jacklovell]

I certainly think you want to pluralise whatever you choose, so that it's clear that this is a list of things you want to load. The docstring can describe what form is necessary for each element in components, but it should be reasonably clear to anybody reading code calling this function what is going on. And to me something like

component_description = VACUUM_VESSEL + DIAGNOSTICS + DIVERTOR_TILES

makes less sense than

mesh_components = VACCUM_VESSEL + DIAGNOSTICS + DIVERTOR_TILES

The latter just reads more naturally, at least to me as a native English speaker.

[Mateasek]

Changed to mesh_components

[vsnever]

I would like to ask for one small feature here. It would be very helpful if import_jet_mesh() returned a list of Mesh instances added to the scenegraph. For example, if I want to make a simulation with and without reflections, I need to change the materials for already loaded meshes or load the meshes again, now with override_material=AbsorbingSurface(). I can change the material by extracting the JET meshes from world.children, but the code would be simpler if import_jet_mesh() returned them as a list.

[Mateasek]

@vsnever I added the return list

[vsnever]

@vsnever I added the return list

Many thanks! When this is merged, I'll update the demos in #21.

[jacklovell]

Thanks Matej! Looks good to me now.