Skip to content

Take a look at that needs-refactoring! #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
szepeviktor wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Take a look at that needs-refactoring! #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0f9bcb
Take a look at that needs-refactoring!
szepeviktor Sep 26, 2020
c860e02
Fix Check types with generics
szepeviktor Sep 26, 2020
6316c9d
Add WP_List_Table stubs with array items
szepeviktor Sep 26, 2020
42267f2
Refine types in stub
szepeviktor Sep 26, 2020
d5bec7f
Merge branch 'develop' into patch-2
szepeviktor Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions classes/BlueChip/Security/Modules/Checklist/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
use BlueChip\Security\Modules;
use BlueChip\Security\Modules\Cron;

/**
* @template TCheck of \BlueChip\Security\Modules\Checklist\Check
*/
class Manager implements Modules\Initializable
{
/**
Expand All @@ -14,7 +17,7 @@ class Manager implements Modules\Initializable
public const ASYNC_CHECK_ACTION = 'bc_security_run_check';

/**
* @var \BlueChip\Security\Modules\Checklist\Check[]
* @var list<TCheck>
*/
private $checks;

Expand Down Expand Up @@ -122,7 +125,7 @@ public function getCheck(string $id): ?Check
* Return list of all implemented checks, optionally filtered.
*
* @param array{meaningful?:bool,monitored?:bool,status?:?bool} $filters [optional] Extra conditions to filter the list by.
* @return Check[]
* @return list<TCheck>
*/
public function getChecks(array $filters = []): array
{
Expand Down
2 changes: 2 additions & 0 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ parameters:
bootstrapFiles:
- tests/static-analysis/bootstrap.php
- autoload.php
stubFiles:
- %currentWorkingDirectory%/tests/static-analysis/class-wp-list-table.stub
ignoreErrors:
# Apply "checkMissingIterableValueType: false" to Psr\Log classes for the time being.
- '#^Method Psr\\Log\\\w+::\w+\(\) has parameter \$context with no value type specified in iterable type array\.$#'
Expand Down
Loading