Open
Conversation
willstott101
force-pushed
the
feature/xmp
branch
from
254970d to
f713425
Compare
Author
|
On this front - would it be sensible to have a lazy image resource parsing api? Since there are many, and if the number implemented were to grow it might quite significantly increase parse time and memory usage for users not interested in those features. Similarly for users ONLY interested in some of the resource blocks, like XMP metadata or thumbnails. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking into #41 and my simple timeline animation psd didn't include 0x0433
Just to kinda dip my toe in the water with the image resources I thought I'd implement a dead simple one.
The test updates are kinda lazy and I don't actually have a use case for the XMP data, so if there's not much interest in merging this that's fine. FYI the parsing of PSD files will fail if the XMP data isn't valid utf8 after this change.
EDIT: Parsing the XML is left as an exercise for the user, as ergonomic XML apis are a very personal decision IMO. And I don't think it'd be logical to add a strongly-typed XMP lib as a dependency, if a pure-rust one even exists.