Fix: delay buffer full flag assigned during drain#7
Open
tomer2141 wants to merge 1 commit intochirlu:masterfrom
Open
Fix: delay buffer full flag assigned during drain#7tomer2141 wants to merge 1 commit intochirlu:masterfrom
tomer2141 wants to merge 1 commit intochirlu:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in situations where the delay is quite large (e.g 20 seconds) and the input file is longer then that time,
the delay buffer full flag will not be true while draining, as a result it will always re-assign the delay buffer index to 0 resulting in not dumping all of the delay buffer.