Skip to content

Fix the case where paste from the context menu does not work in firefox #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
macyabbey wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix the case where paste from the context menu does not work in firefox #52

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b348774
Fix for issue #51, where the context menu paste event does not work i…
Oct 31, 2014
07ced44
Removing unnessecary function call.
Oct 31, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions src/term.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,6 +477,8 @@ Terminal.prototype.initGlobal = function() {
if (this.useStyle) {
Terminal.insertStyle(document, this.colors[256], this.colors[257]);
}

this.fixFirefoxPaste();
};

/**
Expand Down Expand Up @@ -597,6 +599,39 @@ Terminal.bindCopy = function(document) {
});
};

/**
* We set design mode because in firefox, this is the only way
* to get the paste event to fire because of this bug:
* https://bugzilla.mozilla.org/show_bug.cgi?id=846674
*
*/
Terminal.prototype.fixFirefoxPaste = function () {
var window = document.defaultView;

function disableDesignMode () {
if (Terminal.setDesignMode) {
document.designMode = Terminal.originalDesignMode;
Terminal.setDesignMode = false;
}
}

function enableDesignMode () {
Terminal.originalDesignMode = document.designMode;
Terminal.setDesignMode = true;
document.designMode = "on";
}

//When a right click menu is available, enable design mode so the paste event will fire.
on(document, 'contextmenu', enableDesignMode);

//Make sure we snap out of design mode after any action that would hide the context menu
//and actually allow the user to start modifying the document.
on(window, 'blur', disableDesignMode);
on(document, 'mousedown', disableDesignMode, true);
on(window, 'paste', disableDesignMode, true);
};


/**
* Fix Mobile
*/
Expand Down