feat: add debug flag to skip checksum validation of database#150
Open
prototaxites wants to merge 2 commits intochklovski:mainfrom
Open
feat: add debug flag to skip checksum validation of database#150prototaxites wants to merge 2 commits intochklovski:mainfrom
prototaxites wants to merge 2 commits intochklovski:mainfrom
Conversation
|
Having a mini db (and allowing to skip the checksum test) would also improve your own GH Actions by allowing something more than a --version flag test. It looks like the run test is commented out for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @chklovski,
Following up on my suggestion here: #140
This PR adds an optional command-line flag (
dbg_skip_checksum) to skip checksum validation of the CheckM2 database. This will allow us to use a curated, reduced version of the database for unit testing CheckM2 in CI tests for our pipeline, as running CheckM2 with the full database can be very slow (and also needs to be downloaded each time in a CI run).Let me know what you think, and hopefully we can add this PR (or a similar one). This is a real blocker for quick pipeline validation on our end!