[a11y] fix(a11y): associate filter labels to select controls in AIActivityPanel#52
Draft
github-actions[bot] wants to merge 1 commit intomainfrom
Draft
Conversation
Add htmlFor/id pairs to three <label>/<select> pairs in the AIActivityPanel filters panel. Without this association, screen readers cannot announce the label text when users focus the dropdowns. WCAG 2.2 SC 4.1.2 (Name, Role, Value) — Level A Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
Pull request created: #52 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
WCAG 2.2 SC 4.1.2 – Name, Role, Value (Level A)
In
src/components/AIActivityPanel/index.tsx, the filters panel contains three(label)/(select)pairs for Operation, Model, and Sort by. None of the(label)elements had ahtmlForattribute and none of the(select)elements had anid, so the labels were not programmatically associated with their controls.Without this association, screen readers (NVDA, VoiceOver, JAWS) announce the dropdowns without any label — users hear only "combobox" with no context about what the control does.
Fix
Added matching
htmlFor/idpairs to all three filter groups:htmlFor/idaddedai-activity-operation-filterai-activity-model-filterai-activity-sort-filterNo logic changes — purely additive HTML attribute additions.
Verification
npx tsc --noEmit— ✅ clean (exit 0)npm run lint— ✅ no errors (pre-existing warnings only, unrelated to this change)