[perf] Replace 3 static inline styles in ExportDialog with CSS classes#53
Merged
chrisreddington merged 1 commit intomainfrom Mar 3, 2026
Conversation
Move static inline style objects to ExportDialog.module.css: - Stack padding '24px 0' → .loadingContainer - span fontWeight 600 → .visibilityLabel - p fontSize/color/margin → .visibilityCaption Eliminates per-render object allocations from static style props, allowing the browser's style system to cache class-based styles. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
Pull request created: #53 |
chrisreddington
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tier 2 — Render Performance: Inline Style Elimination
Baseline
export-dialog.tsxcontained 3 staticstyle=\{\{}}objects that created new object literals on every render:Files Changed
src/components/ChallengeSandbox/ExportDialog.module.css— 3 new classes addedsrc/components/ChallengeSandbox/export-dialog.tsx— 3 inline styles replaced withclassNamereferences