Fix colour values from external variables in Content.setValuePopupData#893
Open
davidhealey wants to merge 1 commit intochristophhart:developfrom
Open
Fix colour values from external variables in Content.setValuePopupData#893davidhealey wants to merge 1 commit intochristophhart:developfrom
davidhealey wants to merge 1 commit intochristophhart:developfrom
Conversation
ValuePopup::Properties::getColour used ObjectWithDefaultProperties::getColourFrom which does a simple cast chain (uint32)(int64)(var) that doesn't properly handle all var types. Switch to ApiHelpers::getColourFromVar which is the canonical colour conversion used throughout HISE and correctly handles int, int64, and string types. Also add double handling to both ApiHelpers::getColourFromVar and scriptnode::PropertyHelpers::getColourFromVar so colour values that have been through JSON serialization (which converts large integers to doubles) are handled correctly. https://claude.ai/code/session_01K4LR9ibEig4BHFCipQKYDQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Content.setValuePopupData I wanted to use colours and other properties that are stored in variables or retrieved using functions.
ValuePopup::Properties::getColour used ObjectWithDefaultProperties::getColourFrom which does a simple cast chain (uint32)(int64)(var) that doesn't properly handle all var types. Switch to ApiHelpers::getColourFromVar which is the canonical colour conversion used throughout HISE and correctly handles int, int64, and string types.
Also add double handling to both ApiHelpers::getColourFromVar and scriptnode::PropertyHelpers::getColourFromVar so colour values that have been through JSON serialization (which converts large integers to doubles) are handled correctly.
https://claude.ai/code/session_01K4LR9ibEig4BHFCipQKYDQ