Expansion preset favourites#913
Draft
davidhealey wants to merge 4 commits intochristophhart:developfrom
Draft
Conversation
… enum On Linux, resolv.h (included transitively via httplib.h's resolv.h pull-in when __linux__ is defined) defines DELETE as ns_uop_delete which equals 0. This collides with the RestServer::Method::DELETE enum value in switch statements, causing "duplicate case value" errors since GET also equals 0. Undefine DELETE after all system headers are included in RestServer.cpp. https://claude.ai/code/session_0136KCbr58YCTnir9yWDX7jW
- Add Install (.hr1), Relocate Samples, and Uninstall buttons to the expansion column in the preset browser - Selective uninstall: user can keep custom presets, only monolith (.ch*) files are deleted (not the whole samples folder if shared) - Relocate samples: validates all monolith files exist in the new location before writing the link file; shows success message on completion - Install: prompts for sample directory, auto-creates named subfolder unless the chosen directory already matches the expansion name - Add ShowExpansionEditButtons panel property (default: false) to control visibility of these buttons independently of other columns - Remove overwrite confirmation from createLinkFileInFolder - Use ButtonIndexes enum instead of magic numbers when hiding buttons - Force-extract user presets after fresh install so preset browser populates immediately https://claude.ai/code/session_01K6DbeGdttAjpybH9DEckMq Add expansion management buttons to preset browser expansion column - Add/rename/delete buttons to the expansion column with independent showExpansionEditButtons option - Add button installs an .hr1 package; rename button relocates samples; delete button uninstalls the expansion - Fix edit buttons staying visible after deselecting an expansion by clearing the listbox selection before updateButtonVisibility - Promote ButtonIndexes enum to class scope so call sites can use named constants instead of raw integers https://claude.ai/code/session_01K6DbeGdttAjpybH9DEckMq
- Search presets across all available expansions when no expansion is selected; scope search to the selected expansion when one is active - Preserve search wildcard when switching expansions during a search - Add FullPathSearch panel property to prefix results with the expansion name so the user can distinguish same-named presets from different expansions - Always show expansion column during search/filter mode https://claude.ai/code/session_011hoRk8B1Wv3jdut16umVbu
davidhealey
force-pushed
the
expansionPresetFavourites
branch
from
5632702 to
69bcee4
Compare
- Search across all expansion roots, not just the currently loaded one - Favourite toggle now writes to the correct expansion's db.json instead of always modifying the default root's database - Favourite filter shows favourites from all expansions (filtered by selected expansion when applicable) - Renaming a bank, category, or preset updates the db.json keys so favourites are preserved after rename - Add FullPathSearch option mirroring FullPathFavorites for search results - Extract findRootForFile() to deduplicate root-resolution logic https://claude.ai/code/session_01RTEEVbUeVTucyccchRmKpj
davidhealey
force-pushed
the
expansionPresetFavourites
branch
from
69bcee4 to
36882ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #912
Fix preset browser favourites filter across all expansions
across all expansions
the search box was focused but empty (currentWildcard was incorrectly
set to "**" instead of "*")
when no expansion is selected; add getShowFavoritesOnly() getter to
ColumnListModel so the paint() condition can check it without accessing
the protected member directly
https://claude.ai/code/session_01PEwMhvyEVEH2d8vgHfzZpC