[BUG]: Collection affinity not working #6115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Contributor
|
This update also ensures the distributed executor reads the renamed Affected Areas• rust/frontend/src/executor/config.rs This summary was automatically generated by @propel-code-bot |
![propel-code-bot[bot]](https://avatars.githubusercontent.com/in/1179004?s=60&v=4){kind=small}
| let retry_config = &config.retry; | ||
| let backoff = retry_config.into(); | ||
| let client_selection_config = config.client_selection_config.clone(); | ||
| let client_selection_config = config.client_selection.clone(); |
Contributor
There was a problem hiding this comment.
[Maintainability] For consistency with the change you made in DistributedExecutorConfig, consider also renaming the field in the DistributedExecutor struct from client_selection_config to client_selection. This would make the naming consistent across both the config and the executor struct itself.
This would involve:
- Changing the field in the
DistributedExecutorstruct definition. - Updating the local variable name and field initialization in
try_from_config. - Updating
self.client_selection_configtoself.client_selectionin thecount,get,knn, andsearchmethods.
Context for Agents
For consistency with the change you made in `DistributedExecutorConfig`, consider also renaming the field in the `DistributedExecutor` struct from `client_selection_config` to `client_selection`. This would make the naming consistent across both the config and the executor struct itself.
This would involve:
1. Changing the field in the `DistributedExecutor` struct definition.
2. Updating the local variable name and field initialization in `try_from_config`.
3. Updating `self.client_selection_config` to `self.client_selection` in the `count`, `get`, `knn`, and `search` methods.
File: rust/frontend/src/executor/distributed.rs
Line: 96
tanujnay112
approved these changes
Jan 5, 2026
chroma-droid
pushed a commit
that referenced
this pull request
Jan 5, 2026
## Description of changes _Summarize the changes made by this PR._ - Improvements & Bug fixes - Config name was not what was set in the yaml files. Thereby resorting to defaults which is [1.0, 1.0, 1.0] - Instead of changing the yaml, I changed the name in code to align with all the other fields (they all don't have _config suffix) - New functionality - ... ## Test plan _How are these changes tested?_ - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Migration plan None ## Observability plan None ## Documentation Changes None
sanketkedia
added a commit
that referenced
this pull request
Jan 5, 2026
This PR cherry-picks the commit da85e49 onto release/2026-01-02. If there are unresolved conflicts, please resolve them manually. Co-authored-by: Sanket Kedia <kediasanket11121993@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustMigration plan
None
Observability plan
None
Documentation Changes
None