fix(motherload-mine): use direct vein click to prevent mining unreach…#302
Merged
fix(motherload-mine): use direct vein click to prevent mining unreach…#302
Conversation
…able veins (#301) The previous code re-queried the tile object cache by vein ID when attempting to mine, which could return a different vein than the one originally selected. Since ore vein IDs (26661-26664) are shared across many veins in the mine, the query could match a vein in a different mining area, causing the bot to get stuck attempting to mine an unreachable vein. Changed from: rs2TileObjectCache.query().interact(vein.getId()) To: vein.click() This ensures the bot interacts with the exact vein that was found by findClosestVein(), which has already been validated for: - Reachability (nearestReachable) - Correct floor (upstairs/downstairs) - Anti-crash distance checks Bumps version to 1.8.3. Co-authored-by: Michael Zarglis <mike.zarglis@gmail.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…able veins (#301)
The previous code re-queried the tile object cache by vein ID when attempting to mine, which could return a different vein than the one originally selected. Since ore vein IDs (26661-26664) are shared across many veins in the mine, the query could match a vein in a different mining area, causing the bot to get stuck attempting to mine an unreachable vein.
Changed from:
rs2TileObjectCache.query().interact(vein.getId())
To:
vein.click()
This ensures the bot interacts with the exact vein that was found by findClosestVein(), which has already been validated for:
Bumps version to 1.8.3.