Merge pull request #1677 from gmason0/fix/menuaction Update MENU_ACTION_DESCRIPTOR_VANILLA signature#1678
Merge pull request #1677 from gmason0/fix/menuaction
Update MENU_ACTION_DESCRIPTOR_VANILLA signature#1678
Conversation
[ci skip]
This is controlled by net.ipv4.ping_group_range and appears to be disabled by default on many common Linux distros
Rev 236 changed menu action descriptor from "(IIIIIILjava/lang/String;Ljava/lang/String;IIB)V" -> "(IIIIIILjava/lang/String;Ljava/lang/String;III)V"
# Conflicts: # gradle.properties
Update MENU_ACTION_DESCRIPTOR_VANILLA signature
|
Caution Review failedThe pull request is closed. WalkthroughThis PR bumps project and microbot versions in gradle.properties, adds new game-constant identifiers across multiple runelite-api classes (including NpcID, ItemID, AnimationID, DBTableID, InterfaceID, and VarbitID), updates a cryptic clue location coordinate, modifies a method descriptor used in reflection-based menu action resolution, adjusts TCP ping control flow logic on non-Windows platforms, and refactors BankMainBuild script control flow with new conditional branches and label reorganization. Possibly related PRs
✨ Finishing touches
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.40.5)runelite-api/src/main/java/net/runelite/api/NpcID.javarunelite-api/src/main/java/net/runelite/api/NullItemID.javarunelite-api/src/main/java/net/runelite/api/gameval/AnimationID.java
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
No description provided.