-
-
Notifications
You must be signed in to change notification settings - Fork 79
Add Ci workflow to compute code coverage #1674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
looks like secret is not propagated to my fork workflow, synced offline with @sayboras on how to fix it |
e23c409 to
e654f53
Compare
jrajahalme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some back-and-forth between adding/commenting/updating the GH workflow, could you clean up the PR by squashing all or most of that?
I think with the |
e654f53 to
a1cbf90
Compare
|
From offline discussion with @jrajahalme this feedback needs to be addressed: |
a1cbf90 to
b448353
Compare
|
@sayboras are you able to create a test branch for this PR? |
Sure, however, check format seems failing. |
let me fix it |
b448353 to
5faac93
Compare
|
@sayboras format is fixed |
envoy.bazelrc
Outdated
| build:coverage --define=dynamic_link_tests=false | ||
| # Use custom report generator that also generates HTML | ||
| build:coverage --coverage_report_generator=@envoy//tools/coverage:report_generator | ||
| build:coverage --coverage_report_generator=//tools/coverage:cilium_report_generator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, this should be part of cilium/proxy .bazelrc file
Signed-off-by: Kateryna Nezdolii <kateryna.nezdolii@gmail.com>
5faac93 to
b25c8c9
Compare
Workflow computes code coverage for cilium-proxy source files using custom report generator. It relies heavily on bazel remote caching stored in gcs bucket and all reports (per PR) are uploaded to another gcs bucket and stored for 7 days.
Sample report: https://storage.googleapis.com/cilium-proxy-coverage-reports/c08c59a/coverage/html/index.html