Fix MentionsAndKeywords rooms showing badges for all messages#2584
Closed
andrewmurphyio wants to merge 2 commits intocinnyapp:devfrom
Closed
Fix MentionsAndKeywords rooms showing badges for all messages#2584andrewmurphyio wants to merge 2 commits intocinnyapp:devfrom
andrewmurphyio wants to merge 2 commits intocinnyapp:devfrom
Conversation
Rooms set to "Mentions and Keywords" notification mode now correctly show badges only when there are actual highlights (mentions), not for all unread messages. - Extract notificationType to a variable for reuse - Add MentionsAndKeywords check that only counts highlights - Badge count shows highlight count, not total unread count Fixes cinnyapp#2583
The previous fix only applied during RESET (initial load, sync). Live timeline events still used getUnreadInfo() directly, which would show badges for all messages, not just highlights. Now handleTimelineEvent checks notification type and only shows badge for highlights when room is set to MentionsAndKeywords.
Collaborator
|
This is currently in the discussion phase: Rooms set to "Mentions and Keywords" still show badges for all messages · cinnyapp/cinny · Discussion #2811 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2583
Rooms set to "Mentions and Keywords" notification mode now correctly show badges only when there are actual highlights (mentions), not for all unread messages.
Changes
In
getUnreadInfos()(src/app/utils/room.ts):notificationTypeto a variable for reuseMentionsAndKeywordsnotification typehighlight > 0Before
total > 0(any message)totalcount (all unreads)After
highlight > 0(actual mentions)highlightcount (only mentions)Type of change
Checklist