fix: do not attempt to join call on doubleclick if missing permissions#2798
Open
YoJames2019 wants to merge 2 commits intocinnyapp:devfrom
Open
fix: do not attempt to join call on doubleclick if missing permissions#2798YoJames2019 wants to merge 2 commits intocinnyapp:devfrom
YoJames2019 wants to merge 2 commits intocinnyapp:devfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
ajbura
added a commit
to cinnyapp/cla
that referenced
this pull request
Mar 18, 2026
|
Preview: https://2798--pr-cinny.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, if you double clicked a vc channel without the proper permissions it would attempt to join the call but obviously would not be able to, so it would show you a generic element call error screen and you would be stuck in that call unable to leave or join any other call until you refreshed the page.
Now it does not attempt to start/join the call if you do not have permission.
Type of change