Feat/query api #46
Feat/query api #46
Conversation
coderdan
force-pushed
the
feat/query-api
branch
from
073c649 to
e95452c
Compare
- Updated `cipherstash-client` to version 0.28.0 and `cts-common` to 0.3.1 in `Cargo.toml`. - Added new module `eql.rs` to handle encrypted data structures and conversions. - Refactored encryption handling in `lib.rs` to utilize the new `Encrypted` enum from `eql.rs`. - Introduced new `query.rs` module to define query structures and serialization for `SteQueryVec` and `TokenizedSelector`. - Added tests for query serialization in the new `query.rs` module. - Updated various dependencies in `Cargo.lock` to their latest versions, including `serde`, `ahash`, and others.
…-ffi into feat/query-api
…-ffi into feat/query-api
…-ffi into feat/query-api
…-ffi into feat/query-api
…-ffi into feat/query-api
| type JsonContainsQuery, | ||
| } from '@cipherstash/protect-ffi' | ||
| import { Client, type QueryResult } from 'pg' | ||
| import { encryptQuery } from '../../lib/load.cjs' |
There was a problem hiding this comment.
The integration tests are intended to use @cipherstash/protect-ffi as a dependency through package.json (similar to an end user) instead of importing from ../../lib.
Can you please update this import to be consistent with the other imports from @cipherstash/protect-ffi?
There was a problem hiding this comment.
Yep no problem. I hadn't noticed that.
|
|
||
| // Import a shared encryptConfig from common.js | ||
| import { encryptConfig } from './common.js' | ||
| import { encryptQuery } from '../../lib/load.cjs' |
There was a problem hiding this comment.
Same comment here about importing from@cipherstash/protect-ffi instead of ../../lib.
| default: '' | ||
| secrets: | ||
| CIPHERSTASH_SUITE_PRIVATE_SSH_KEY: | ||
| required: true |
There was a problem hiding this comment.
Is the intent to revert the SSH changes before merging? Ideally we'd avoid using unpublished versions of cipherstash-client and don't need to support private GitHub dependencies.
There was a problem hiding this comment.
Looks like CI isn't running against this PR because the test workflow file is invalid (missing a secret): https://github.com/cipherstash/protectjs-ffi/actions/runs/18696048330.
No description provided.