Open
Conversation
sahil-kale
force-pushed
the
motor-stall
branch
from
1567a0b to
6b89aaf
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds documentation and a header file for motor stall detection in brushed DC motors. The content introduces the theoretical background of DC motor stall conditions and provides a template for implementing stall detection algorithms in C.
Key changes:
- Introduces LaTeX documentation explaining stalled-rotor conditions and detection principles
- Provides electrical models and mathematical relationships for DC motors
- Defines C data structures and API for motor stall detection implementation
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/motor_stall.tex | Adds comprehensive documentation on DC motor stall detection theory, including electrical models, mathematical relationships, and detection strategies |
| src/code/motor_stall/motor_stall_header.h | Defines C API structures for motor stall detection with input data and motor handle types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| \spoilerline | ||
|
|
||
| \subsection{Defining a Stalled-Rotor Condition} | ||
| A stalled-rotor condiition occurs when the motor's rotor can no longer rotate, typically due to an excessive load or mechanical obstruction. If a motor is left in this condition, it may result in overheating (and damage to the motor windings), increased power consumption, and depending on the system, cause damage to other systems or people. Accordingly, implementing stall detection is a classic requirement for active control systems that use motors. |
There was a problem hiding this comment.
Spelling error: "condiition" should be "condition".
Suggested change
| A stalled-rotor condiition occurs when the motor's rotor can no longer rotate, typically due to an excessive load or mechanical obstruction. If a motor is left in this condition, it may result in overheating (and damage to the motor windings), increased power consumption, and depending on the system, cause damage to other systems or people. Accordingly, implementing stall detection is a classic requirement for active control systems that use motors. | |
| A stalled-rotor condition occurs when the motor's rotor can no longer rotate, typically due to an excessive load or mechanical obstruction. If a motor is left in this condition, it may result in overheating (and damage to the motor windings), increased power consumption, and depending on the system, cause damage to other systems or people. Accordingly, implementing stall detection is a classic requirement for active control systems that use motors. |
|
🔥 🔥 🔥 🔥 🔥 🔥 🔥 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.