sorting, revert #75 partly #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with the implementation of proper diffs (see #75), these to functions are not necessary anymore.
…or portgroups inside XML" This partly reverts commit 4c55908 (#75). The part 'human readable diff' is kept, the part 'correct sort...' is reverted. Fixing the sort in the provider only is the wrong approach. This module uses the function defined in lib/puppet_x/libvirt/sort_elements.rb to have equal XML's to compare. The sort_elements function is used in the provider to ensure sorting of the 'is' part. The 'should' part is sorted using the function libirt::normalxml on the template XML output. See Bug #85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.