Support SimpleSAMLphp 2.5 (Symfony 7.x). Remove unmaintained Symfony versions #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you @nathanjrobertson . I did a little testing in the current SSP and it worked for me. |
Contributor
Author
|
Great, thanks @pradtke. Could you please tag a release as well so that it can flow through |
Contributor
@nathanjrobertson I've tagged a v5.1.0 |
Contributor
Author
Awesome, thank you @pradtke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably the smallest PR possible, but this allows
symfony/cacheversion 7.x, which is what SimpleSAMLphp 2.5 will be based on. Both SimpleSAMLphp 2.5 and Symfony 7.4 are due to be released later this month.This PR also removes support for
symfony/cacheversion 3.x and 4.x, because they are no longer maintained by the Symfony project, and users should upgrade to at least 5.x.I've been testing this against SimpleSAMLphp 2.5.0-rc2 and it works for me.
Closes #107