- 
                Notifications
    You must be signed in to change notification settings 
- Fork 12
          Update from setup.py to pyproject.toml
          #164
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
540a8db    to
    336618a      
    Compare
  
    | @mcdonnnj - I'm not sure what kind of version bump to apply here, if any. | 
| The  The  | 
| example = "example.example:main" | ||
|  | ||
| [project.urls] | ||
| Mission = "https://www.cisa.gov/cybersecurity" | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This URL was specified in setup.py, but I didn't have a particular place to put it in pyproject.toml.  I'm open to changing Mission to something else or removing this URL altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on board with what you have here.
| I realize that we want  | 
This is because this file now contains configurations for test tools. Also remove test tool config files that no longer exist.
These may be of use to folks who are editing pyproject.toml for a descendant of this skeleton repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks like a solid start to me.  Thanks for getting us switched over to pyproject.toml. 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request migrates the project from a setup.py-based build configuration to a modern pyproject.toml-based configuration using the Hatchling build backend. This modernization consolidates configuration files and follows current Python packaging best practices (PEP 517/518).
- Migrates from setup.pytopyproject.tomlwith Hatchling as the build backend
- Consolidates pytest.iniand.isort.cfgconfigurations intopyproject.toml
- Updates GitHub labeler configuration to reference the new configuration file
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description | 
|---|---|
| setup.py | Removed legacy setup.py file (116 lines) | 
| pytest.ini | Removed standalone pytest configuration file | 
| .isort.cfg | Removed standalone isort configuration file | 
| pyproject.toml | Added comprehensive project configuration including build system, dependencies, tool configurations, and metadata | 
| .github/labeler.yml | Updated file references from setup.py,.isort.cfg, andpytest.initopyproject.toml | 
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
🗣 Description
This pull request updates our project packaging configuration from using a
setup.pyfile to using apyproject.tomlfile with ahatchlingbuild backend.💭 Motivation and context
Resolves #163.
🧪 Testing
All automated tests pass.
✅ Pre-approval checklist
bump_versionscript if this repository is versioned and the changes in this PR warrant a version bump.✅ Pre-merge checklist
✅ Post-merge checklist