Skip to content

Conversation

@jsf9k
Copy link
Member

@jsf9k jsf9k commented Oct 28, 2025

🗣 Description

This pull request adds a code style badge to the README.md file.

💭 Motivation and context

Badges are sweet!!!

See also cisagov/skeleton-generic#228.

🧪 Testing

I tested using my eyeballs.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k self-assigned this Oct 28, 2025
@jsf9k jsf9k added the documentation This issue or pull request improves or adds to documentation label Oct 28, 2025
@jsf9k jsf9k added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Oct 28, 2025
@jsf9k jsf9k moved this to In Progress in Next Kraken Oct 28, 2025
@jsf9k jsf9k changed the title Add a few more badges Add a code style badge Oct 28, 2025
@jsf9k jsf9k force-pushed the documentation/add-badges branch from 447e81a to 3638673 Compare October 28, 2025 20:15
@jsf9k jsf9k moved this from In progress to Review in progress in Skeleton Maintenance Oct 28, 2025
@jsf9k jsf9k marked this pull request as ready for review October 28, 2025 20:32
@jsf9k jsf9k requested review from dav3r and mcdonnnj as code owners October 28, 2025 20:32
README.md Outdated
[![CodeQL](https://github.com/cisagov/skeleton-python-library/workflows/CodeQL/badge.svg)](https://github.com/cisagov/skeleton-python-library/actions/workflows/codeql-analysis.yml)
[![Coverage Status](https://coveralls.io/repos/github/cisagov/skeleton-python-library/badge.svg?branch=develop)](https://coveralls.io/github/cisagov/skeleton-python-library?branch=develop)

[![Code Style](https://img.shields.io/badge/Code%20Style-Black-black
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we have this badge on its own line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No real reason. I'll remove the blank line.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see commit 45be309.

jsf9k and others added 2 commits October 29, 2025 08:49
This agrees with what is done in the code style badge for the black project.

Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This issue or pull request improves or adds to documentation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Projects

Status: In Progress
Status: Review in progress

Development

Successfully merging this pull request may close these issues.

3 participants