Merged
Conversation
When we bump columnar version, some tests fail because of the output change. Instead of changing those lines everytime, I think it is better to normalize it in tests.
Codecov Report
@@ Coverage Diff @@
## main #6917 +/- ##
==========================================
- Coverage 93.28% 93.27% -0.01%
==========================================
Files 269 269
Lines 57597 57596 -1
==========================================
- Hits 53727 53723 -4
- Misses 3870 3873 +3 |
onurctirtir
approved these changes
May 8, 2023
JelteF
approved these changes
May 8, 2023
hanefi
added a commit
that referenced
this pull request
May 8, 2023
When we bump columnar version, some tests fail because of the output change. Instead of changing those lines every time, I think it is better to normalize it in tests. (cherry picked from commit 06e6f8e)
hanefi
added a commit
that referenced
this pull request
May 9, 2023
When we bump columnar version, some tests fail because of the output change. Instead of changing those lines every time, I think it is better to normalize it in tests. (cherry picked from commit 06e6f8e)
emelsimsek
pushed a commit
that referenced
this pull request
May 24, 2023
When we bump columnar version, some tests fail because of the output change. Instead of changing those lines every time, I think it is better to normalize it in tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we bump columnar version, some tests fail because of the output change. Instead of changing those lines every time, I think it is better to normalize it in tests.
Related: citusdata/tools#311