Skip to content

fix only canadian postal codes were normalized, split specific country address normalization #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
masetto wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix only canadian postal codes were normalized, split specific country address normalization #23

masetto wants to merge 1 commit into from

Conversation

@masetto
Copy link

@masetto masetto commented Oct 8, 2024

  • added "IT" country to postal code normalization
  • fixed typo about postal code normalization: previously only Canadian addresses were normalised
  • moved specific country address normalization to a method named as normalize_address_<country>
  • add some extension translations
  • fixed contact view url: now it works with WordPress and other CMS.

@nganivet
Copy link
Contributor

nganivet commented Oct 8, 2024

@masetto Thanks for this comprehensive PR, good improvements
@yashodha Can you please review as part of the civix upgrade / new release? Comments deleted in this PR will need to be restored. If these improvements are in the new release we should have release notes. Thanks.

@masetto masetto mentioned this pull request Oct 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@masetto @nganivet