-
Notifications
You must be signed in to change notification settings - Fork 0
Visual Defragmentation: Premium Grid & Alchemical Theme #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
a9d09ee
b98955b
900968b
aa456b8
6e79f18
b65f631
c1654f7
30d89cb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,136 @@ | ||||||||||
| import React from 'react'; | ||||||||||
| import { ArrowRight, Activity, Lock } from 'lucide-react'; | ||||||||||
|
||||||||||
| import { ArrowRight, Activity, Lock } from 'lucide-react'; | |
| import { ArrowRight, Activity } from 'lucide-react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line uses a hardcoded hex value #0F172A. To adhere to the new design system, please use the corresponding CSS variable. In this case, it should be var(--color-black).
| <div className="w-full h-24 bg-[#0F172A] border border-white/10 rounded-lg"></div> | |
| <div className="w-full h-24 bg-[var(--color-black)] border border-white/10 rounded-lg"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line uses a hardcoded hex value #F8FAFC. The design system defines this color as var(--color-white). Please use the CSS variable for consistency.
| <div className="w-full h-24 bg-[#F8FAFC] border border-white/10 rounded-lg"></div> | |
| <div className="w-full h-24 bg-[var(--color-white)] border border-white/10 rounded-lg"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be an extra space at the beginning of this line, which makes its indentation inconsistent with the <span> for 'Unit A' on line 107. This could be a formatting typo and should be corrected for consistency.
| <span className="text-[10px] uppercase font-bold px-2 py-1 bg-white/10 rounded text-white/80"> | |
| <span className="text-[10px] uppercase font-bold px-2 py-1 bg-white/10 rounded text-white/80"> |
Copilot
AI
Feb 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra leading space in the JSX. Should be <span instead of <span for consistent formatting.
| <span className="text-[10px] uppercase font-bold px-2 py-1 bg-white/10 rounded text-white/80"> | |
| <span className="text-[10px] uppercase font-bold px-2 py-1 bg-white/10 rounded text-white/80"> |
Copilot
AI
Feb 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra leading space before the comment. Should be {/* GRID */} instead of {/* GRID */}.
| {/* GRID */} | |
| {/* GRID */} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -162,4 +162,4 @@ code { | |
| h3 { | ||
| font-size: 1.5rem; | ||
| } | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
Lockicon is imported fromlucide-reactbut is not used within the component. It's good practice to remove unused imports to keep the code clean.