Skip to content

Fix Stripe webhook raw body handling#10

Draft
cjo93 wants to merge 1 commit intomainfrom
codex/find-and-fix-critical-bug-in-codebase
Draft

Fix Stripe webhook raw body handling#10
cjo93 wants to merge 1 commit intomainfrom
codex/find-and-fix-critical-bug-in-codebase

Conversation

@cjo93
Copy link
Owner

@cjo93 cjo93 commented Dec 23, 2025

Summary

  • prevent JSON parsing from mutating Stripe webhook payloads so signature verification can succeed
  • keep JSON parsing enabled for all non-webhook routes

Testing

  • npm test -- --runInBand

Codex Task

@gemini-code-assist
Copy link

Summary of Changes

Hello @cjo93, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where the application's global JSON parsing middleware was inadvertently modifying Stripe webhook request bodies before signature verification could occur, leading to verification failures. The change introduces a conditional middleware that bypasses JSON parsing for the designated Stripe webhook endpoint, ensuring the raw request body is preserved for proper signature validation, thereby stabilizing webhook functionality without affecting other API routes.

Highlights

  • Stripe Webhook Handling: Implemented a fix to prevent JSON parsing from mutating Stripe webhook payloads, which is crucial for successful signature verification.
  • Conditional JSON Parsing: Modified the application's middleware to skip JSON parsing specifically for the Stripe webhook route (/api/payments/webhook), while retaining JSON parsing for all other non-webhook routes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue with Stripe webhook signature verification by preventing the JSON body parser from consuming the raw request body for the webhook endpoint. The approach taken is to conditionally apply the express.json() middleware. While this works, I've left a comment suggesting a more robust, idiomatic Express.js solution that relies on middleware ordering to avoid hardcoding URL paths. This would improve the long-term maintainability of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant