This repository was archived by the owner on Dec 1, 2023. It is now read-only.
Open
Conversation
ppamorim
reviewed
Oct 10, 2019
ppamorim
left a comment
ppamorim
left a comment
There was a problem hiding this comment.
I think you should migrate to WKWebView
Author
|
@ppamorim This is not the scope of this ticket. |
@ppamorim Here is a fork that includes iOS 13+ support including dark mode, solves the upload to App Store issues, as well. Edit: Shoulda explicitly said "Includes WKWebView" to avoid confusion. App Store issues arose since WKWebView is necessary to be approved for App Store. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests adds support for iOS 13+ dark mode while maintaining full backwards compatibility - by using CSS media queries. Should fix #134.
To build with Xcode 11, I also needed to move the project to Swift 5 which might collide with #203, but I'm free to rebase these changes once the other pull request is merged.
Thanks!