Open
Conversation
israelmcmc
force-pushed
the
interfaces
branch
2 times, most recently
from
87d3286 to
317ab82
Compare
source in one frame with data or orientations in a different frame
without conversion.
* performance patches to COSILike:
- make sure data and bg use same CDS order as response so we don't
have to possibly permute the expectation each time we compute it
- don't check for change in point source position via the .sky_coord
property of PointSource.position -- accessing this property creates a new
SkyCoord from the underlying sky direction each time, which is
an expensive operation. Instead, check the individual elements of
the sky direction to see if any have changed.
- do more nparray additions in place
* rewrite one line of FullDetectorResponse to clarify that it doesn't
matter which frame the HealpxiAxis is uing at that point, as we are
passing theta/phi instead of a SkyCoord.
* remove old, unneeded code from GalacticResponse
frame different from galactic
even if source is in a different coordinate frame
Replace print() statements with logger.info() in pipeline tasks (fixe…
Added an option to include Poisson fluctuations on the injected source.
* Change all Iterable[EventInterface] and Iterable[PhotonInterface] to EventDataInterface and PhotonListInterface. * EventSelection interface no longer defined __call__ and mask(). select() gained the early_stop parameter. * `direction_lon_radians` was renamed `direction_lon_rad_sc`. This is to make it consistent with other properties that define the coordinate or convention in the name, to make it less error-prone * Similarly, `polarization_angle_rad` changed to `polarization_angle_rad_stereo` Signed-off-by: Israel Martinez <imc@umd.edu>
Changed the default value of 'fluctuate' parameter to True.
Add the fluctuate option to the source injector
… numpy arrays. The helper from_astropy class methods is provided (old init) Signed-off-by: Israel Martinez <imc@umd.edu>
…y direction * New intermediate class called PhotonListWithDirectionInSCFrame. The corresponding interface is the input of FarFieldInstrumentResponseFunctionInterface * FarFieldSpectralInstrumentResponseFunctionInterface with input PhotonListWithDirectionAndEnergyInSCFrame * Similar for polarization IRF Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Allow implementation to use already cached numpy arrays.
Signed-off-by: Israel Martinez <imc@umd.edu>
- Using FITS now. - Response not needed. Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
Fix Astropy-related performance issue with GCRS object comparison
Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
…ood, apart from the last plot which might need some further review.
- Move get_lctutorial_data.py to speclc_grbdc3_prep.ipynb - Use fetch_wasabi with checksum instead of custom get_data (wasabipath,outpath,unzip) - No need for unzipping step Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
# Conflicts: # cosipy/pipeline/src/io.py # cosipy/pipeline/task/task.py
… mistakes and missed some calculations while trying to refactor the GRB tutorial based off the Crab tutorial. Those issues are fixed now and the last plot looks better.
…al to work with interfaces
- Use .fits orientation file from develop instead of .ori from DC2 - Add missing poisson_conf_interval import - Use updated response file from develop instead of DC2 Signed-off-by: Israel Martinez <imc@umd.edu>
# Conflicts: # docs/tutorials/spectral_fits/continuum_fit/grb/SpectralFit_GRB.ipynb
- The source variable was not updated after the transform_to(self._gcrs) call (is not an inplace operation) - ez_cart was not normalized before taking the dot product to compare to the cos(angle) Signed-off-by: Israel Martinez <imc@umd.edu>
Signed-off-by: Israel Martinez <imc@umd.edu>
…11916 Signed-off-by: Israel Martinez <imc@umd.edu>
# Conflicts: # cosipy/source_injector/source_injector.py # docs/tutorials/source_injector/Point_source_injector.ipynb
Signed-off-by: Israel Martinez <imc@umd.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.