Skip to content

Conversation

@fghdotio
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2025

⚠️ No Changeset found

Latest commit: 1d98ace

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Nov 26, 2025

Deploy Preview for liveccc ready!

Name Link
🔨 Latest commit 1d98ace
🔍 Latest deploy log https://app.netlify.com/projects/liveccc/deploys/694b9fce3c1665000836778f
😎 Deploy Preview https://deploy-preview-332--liveccc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 36 (🟢 up 2 from production)
Accessibility: 88 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 26, 2025

Deploy Preview for apiccc ready!

Name Link
🔨 Latest commit 1d98ace
🔍 Latest deploy log https://app.netlify.com/projects/apiccc/deploys/694b9fcefe3ec1000824d7ab
😎 Deploy Preview https://deploy-preview-332--apiccc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 80 (🔴 down 18 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 94 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 26, 2025

Deploy Preview for appccc ready!

Name Link
🔨 Latest commit 1d98ace
🔍 Latest deploy log https://app.netlify.com/projects/appccc/deploys/694b9fce5024c600081f2623
😎 Deploy Preview https://deploy-preview-332--appccc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 67 (🔴 down 10 from production)
Accessibility: 89 (🟢 up 1 from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 26, 2025

Deploy Preview for docsccc ready!

Name Link
🔨 Latest commit 1d98ace
🔍 Latest deploy log https://app.netlify.com/projects/docsccc/deploys/694b9fce7be9c9000887c230
😎 Deploy Preview https://deploy-preview-332--docsccc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 72 (🟢 up 9 from production)
Accessibility: 88 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fghdotio, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the @ckb-ccc/rgbpp package by refactoring its core dependencies for better modularity and streamlining its integration within the project's playground. It introduces robust documentation and a practical example for RGB++ xUDT issuance, making it easier for developers to understand and implement RGB++ applications. Additionally, improvements to BTC Assets API configuration and new Bitcoin balance query capabilities contribute to a more flexible and feature-rich development experience.

Highlights

  • Core Dependency Refactoring: The @ckb-ccc/rgbpp package has undergone a significant refactoring, migrating its core dependencies from @ckb-ccc/shell to @ckb-ccc/core and other specific sub-packages like @ckb-ccc/spore and @ckb-ccc/udt. This improves modularity and clarifies dependencies.
  • Enhanced BTC Assets API Configuration: The BTC Assets API configuration now includes an isMainnet flag, and the authentication logic has been streamlined by removing the generateToken and init methods, making token and origin requirements conditional on the network.
  • New RGB++ xUDT Issuance Guide and Example: A comprehensive development guide (RGBPP_UDT_ISSUANCE_GUIDE.md) and a fully functional example (RGBPP_UDT_ISSUANCE) have been added to the playground, demonstrating the complete RGB++ xUDT issuance flow.
  • Playground Integration of RGB++: The playground environment has been updated to fully support @ckb-ccc/rgbpp, including its exports in the Monaco editor and making the library available in the execution context.
  • Bitcoin Balance Query Functionality: New interfaces and a getBalance method have been introduced in RgbppBtcWallet to allow querying Bitcoin address balances via the BTC Assets API.
  • RGB++ Cell Creation Utility: A new createRgbppUdtIssuanceCells method has been added to RgbppUdtClient to facilitate the creation of necessary RGB++ cells for UDT issuance.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces RGB++ support to the playground, including a new example for UDT issuance and a development guide. The changes involve refactoring dependencies, updating API client logic, and adding new features like getBalance. Overall, the changes are well-structured. I've identified a couple of issues in the new playground example code, including incorrect logic for network detection and a minor typo, and have provided suggestions for fixes.

},
);
if (!btcRgbppSigner) {
throw new Error("Failed to create browser RGBPP BTC singer");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's a typo in the error message. 'singer' should be 'signer'.

Suggested change
throw new Error("Failed to create browser RGBPP BTC singer");
throw new Error("Failed to create browser RGBPP BTC signer");

@fghdotio fghdotio changed the title for deployment preview purpose For RGB++ features deployment preview purpose Nov 26, 2025
@fghdotio fghdotio changed the title For RGB++ features deployment preview purpose For RGB++ features preview purpose Nov 26, 2025
fghdotio and others added 22 commits December 2, 2025 14:13
…tection to avoid issues with minified code in production builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants