-
Notifications
You must be signed in to change notification settings - Fork 32
feat(udt): add udt info querying methods (fix #261 merge conflicts) #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| "@ckb-ccc/ssri": minor | ||
| "@ckb-ccc/udt": minor | ||
| "@ckb-ccc/core": patch | ||
| --- | ||
|
|
||
| feat(udt): udt info querying methods | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -315,6 +315,11 @@ export type CellAnyLike = { | |
| * This class provides a unified interface for handling cells before they are included in a transaction, | ||
| * or for cells that are already part of the blockchain state. | ||
| * | ||
| * @remarks | ||
| * When representing an output of a transaction being built, which does not have a deterministic `outPoint` yet, | ||
| * this class should be used without an `outPoint`. Once the transaction is on-chain, its outputs can be | ||
| * represented as `Cell` instances with a defined `outPoint`. | ||
| * | ||
| * @public | ||
| */ | ||
| export class CellAny { | ||
|
|
@@ -464,6 +469,12 @@ export type CellLike = CellAnyLike & | |
| /** | ||
| * Represents an on-chain CKB cell, which is a `CellAny` that is guaranteed to have an `outPoint`. | ||
| * This class is typically used for cells that are already part of the blockchain state, such as transaction inputs. | ||
| * | ||
| * @remarks | ||
| * An `outPoint` should only be included when it is deterministic. | ||
| * For example, an output cell in a transaction currently being built does not have a deterministic `outPoint` yet, | ||
| * and should be represented as a `CellAny` without an `outPoint`. This helps simplify logic elsewhere in the library. | ||
| * | ||
| * @public | ||
| */ | ||
| export class Cell extends CellAny { | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ashuralyk as you can see from here I personally did not make any change to CellAny, it just got updated to the current master version, see: https://github.com/ckb-devrel/ccc/blob/master/packages/core/src/ckb/transaction.ts#L320
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
@@ -1090,6 +1101,7 @@ export class WitnessArgs extends mol.Entity.Base< | |
| /** | ||
| * Convert a bytes to a num. | ||
| * | ||
| * @deprecated Use `Udt.balanceFrom` from `@ckb-ccc/udt` instead | ||
| * @public | ||
| */ | ||
| export function udtBalanceFrom(dataLike: BytesLike): Num { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changeset includes a
minorversion bump for@ckb-ccc/ssri. However, based on the file changes in this pull request, there are no modifications to thessripackage. Bumping the version of an unchanged package could be misleading. Please consider removing this line if the version bump for@ckb-ccc/ssriis not intentional.