-
Notifications
You must be signed in to change notification settings - Fork 32
feat(did-ckb): add did-ckb package for basic did operations #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release
Are you sure you want to change the base?
Conversation
Hanssen0
commented
Dec 16, 2025
- I have read the Contributing Guidelines
* @noble/hashes/sha2 * @noble/curves/secp256k1
🦋 Changeset detectedLatest commit: 97d6c80 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for appccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for apiccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for liveccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @Hanssen0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the project's capabilities by introducing a dedicated package for DID CKB operations. It lays the groundwork for managing decentralized identities on the CKB network, providing essential functions for their lifecycle and integration with existing core components. The inclusion of comprehensive examples will aid developers in quickly adopting these new features. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the new @ckb-ccc/did-ckb package, providing essential functionalities for Decentralized Identifier (DID) operations on CKB. The changes are comprehensive, including the core logic for creating, transferring, and destroying DIDs, along with necessary codec implementations for data serialization. The addition of DidCkb to KnownScript and its configurations for both mainnet and testnet are correctly implemented.
The new package is well-integrated into the existing ecosystem, with updates to the shell package, playground, and documentation configuration. The inclusion of clear and practical examples is particularly helpful, demonstrating the usage of the new DID features effectively.
I've found one minor issue regarding the package description in package.json. Otherwise, the code is well-structured, clean, and follows the project's conventions. Great work on this feature!
| { | ||
| "name": "@ckb-ccc/did-ckb", | ||
| "version": "0.0.0", | ||
| "description": "UDT", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package description is currently "UDT", which appears to be incorrect for a package related to DIDs. To avoid confusion for developers using this package, it should be updated to accurately reflect its functionality. A more descriptive text, such as "CCC's support for DID on CKB", would be more appropriate.
| "description": "UDT", | |
| "description": "CCC's support for DID on CKB", |
✅ Deploy Preview for docsccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
