Skip to content

Conversation

@Hanssen0
Copy link
Member

@changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2025

🦋 Changeset detected

Latest commit: 97d6c80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@ckb-ccc/shell Minor
@ckb-ccc/did-ckb Patch
@ckb-ccc/core Minor
@ckb-ccc/ccc Patch
@ckb-ccc/eip6963 Patch
@ckb-ccc/joy-id Patch
@ckb-ccc/lumos-patches Patch
@ckb-ccc/nip07 Patch
@ckb-ccc/okx Patch
@ckb-ccc/rei Patch
@ckb-ccc/spore Patch
@ckb-ccc/ssri Patch
@ckb-ccc/udt Patch
@ckb-ccc/uni-sat Patch
@ckb-ccc/utxo-global Patch
@ckb-ccc/xverse Patch
ckb-ccc Patch
@ckb-ccc/connector Patch
@ckb-ccc/connector-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Dec 16, 2025

Deploy Preview for appccc ready!

Name Link
🔨 Latest commit 97d6c80
🔍 Latest deploy log https://app.netlify.com/projects/appccc/deploys/694165c6197045000849eb4f
😎 Deploy Preview https://deploy-preview-337--appccc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 63 (🔴 down 14 from production)
Accessibility: 89 (🟢 up 1 from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 92 (🔴 down 8 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 16, 2025

Deploy Preview for apiccc ready!

Name Link
🔨 Latest commit 97d6c80
🔍 Latest deploy log https://app.netlify.com/projects/apiccc/deploys/694165c6a057ca0008ded451
😎 Deploy Preview https://deploy-preview-337--apiccc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 80 (🔴 down 18 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 95 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 16, 2025

Deploy Preview for liveccc ready!

Name Link
🔨 Latest commit 97d6c80
🔍 Latest deploy log https://app.netlify.com/projects/liveccc/deploys/694165c6c5d23f0009502ad3
😎 Deploy Preview https://deploy-preview-337--liveccc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 35 (🟢 up 1 from production)
Accessibility: 88 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Hanssen0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the project's capabilities by introducing a dedicated package for DID CKB operations. It lays the groundwork for managing decentralized identities on the CKB network, providing essential functions for their lifecycle and integration with existing core components. The inclusion of comprehensive examples will aid developers in quickly adopting these new features.

Highlights

  • New DID CKB Package: Introduced a new package, @ckb-ccc/did-ckb, which provides core functionalities for Decentralized Identifiers (DIDs) on the CKB blockchain.
  • DID CKB Script Integration: Added the KnownScript.DidCkb definition to the @ckb-ccc/core package, including specific configurations for both Mainnet and Testnet environments.
  • DID Operations: Implemented functions for basic DID CKB operations: createDid to mint new DIDs, destroyDid to remove them, and transferDid to change their ownership.
  • Example Usage: Included new example scripts in packages/examples demonstrating how to create, destroy, and transfer DID CKB cells, including an example for creating a DID with a local ID and PLC authorization.
  • Dependency Updates: Updated dependencies across packages/examples, packages/playground, and packages/shell to integrate the new @ckb-ccc/did-ckb package and related cryptographic libraries (@noble/curves, @noble/hashes).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the new @ckb-ccc/did-ckb package, providing essential functionalities for Decentralized Identifier (DID) operations on CKB. The changes are comprehensive, including the core logic for creating, transferring, and destroying DIDs, along with necessary codec implementations for data serialization. The addition of DidCkb to KnownScript and its configurations for both mainnet and testnet are correctly implemented.

The new package is well-integrated into the existing ecosystem, with updates to the shell package, playground, and documentation configuration. The inclusion of clear and practical examples is particularly helpful, demonstrating the usage of the new DID features effectively.

I've found one minor issue regarding the package description in package.json. Otherwise, the code is well-structured, clean, and follows the project's conventions. Great work on this feature!

{
"name": "@ckb-ccc/did-ckb",
"version": "0.0.0",
"description": "UDT",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The package description is currently "UDT", which appears to be incorrect for a package related to DIDs. To avoid confusion for developers using this package, it should be updated to accurately reflect its functionality. A more descriptive text, such as "CCC's support for DID on CKB", would be more appropriate.

Suggested change
"description": "UDT",
"description": "CCC's support for DID on CKB",

@netlify
Copy link

netlify bot commented Dec 16, 2025

Deploy Preview for docsccc ready!

Name Link
🔨 Latest commit 97d6c80
🔍 Latest deploy log https://app.netlify.com/projects/docsccc/deploys/694165c69f0ee40008f924ba
😎 Deploy Preview https://deploy-preview-337--docsccc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 66 (🟢 up 3 from production)
Accessibility: 88 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants