Fix issue #90: Add regex escape for format regex generation#91
Open
abhi-patel wants to merge 1 commit intoclemens:masterfrom
Open
Fix issue #90: Add regex escape for format regex generation#91abhi-patel wants to merge 1 commit intoclemens:masterfrom
abhi-patel wants to merge 1 commit intoclemens:masterfrom
Conversation
Owner
|
Sorry, I missed this PR because you created it while I was on vacation. :) @abhi-patel Please provide a test with it, then I'll merge it right away. |
Author
|
@dima4p @clemens - There is one issue with this solution, that is this will not work correctly with formats containing '%-m' or '%-d', as '-' is also regex special character and Regexp.escape will escape that as well. I am thinking on best possible work around for this, meanwhile if you can think of some better way to fix that, let me know. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.