refactor(clerk-js): Improve input + button group styling

[alexcarpenter]

Description

Improve implementations of input + button usage, specifically PasswordInput and SecretInputWithToggle. Removes the absolutely positioned button in favor of flex + increase the touch area of the button by making it fill the space.

BEFORE

Screen.Recording.2025-10-28.at.9.18.31.AM.mov

AFTER

Screen.Recording.2025-10-28.at.9.19.12.AM.mov

Checklist

• pnpm test runs as expected.
• pnpm build runs as expected.
• (If applicable) JSDoc comments have been added or updated for any package exports
• (If applicable) Documentation has been updated

Type of change

• 🐛 Bug fix
• 🌟 New feature
• 🔨 Breaking change
• 📖 Refactoring / dependency upgrade / documentation
• other:

Summary by CodeRabbit

• Style
  • Enhanced input and button styling for improved visual consistency
  • Increased touch target area for buttons
  • Improved focus indicators and border styling
  • Refined layout and positioning for better alignment

[changeset-bot]

🦋 Changeset detected

Latest commit: 5f7cd4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
clerk-js-sandbox	Ready	Preview	Comment	Oct 28, 2025 2:37pm

[coderabbitai]

Walkthrough

A patch release for @clerk/clerk-js updates UI component styling by replacing absolutely-positioned buttons with inline IconButtons, refactoring input and container styling to use variant-based themes, and improving focus and error state handling through focus-within styling patterns.

Changes

Cohort / File(s)	Summary
Changeset .changeset/full-hounds-find.md	Documents patch release with UI improvements: button touch area enhancements, input/button group styling refinements, and removal of absolute positioning.
UI Components Styling packages/clerk-js/src/ui/components/ApiKeys/ApiKeysTable.tsx, packages/clerk-js/src/ui/elements/PasswordInput.tsx	Refactored reveal/show-password buttons from positioned Button to inline IconButton with improved styling. Updated input elements to use variant='unstyled', replaced absolute positioning with theme-based border variants, and centralized focus-within state handling in containers.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Focus areas: IconButton integration and styling migration in both components; verify focus-within state handling and border variant application are consistent; confirm input variant change doesn't affect accessibility or default styling assumptions.

Poem

A rabbit hops through styled components with glee, 🐰
Positioning buttons? Nay—inline they'll be!
With IconButton's grace and focus so keen,
The prettiest input fields ever seen,
Unstyled, refined, a UX dream! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "refactor(clerk-js): Improve input + button group styling" is clear and directly aligned with the pull request's objectives. The changeset and file modifications confirm that the PR addresses styling improvements for input and button components, including removal of absolute positioning, increased touch area through flex-based layout, and enhanced styling. The title uses specific language ("Improve input + button group styling") rather than vague terms, and the "refactor(clerk-js)" prefix follows conventional commit format while clearly identifying the package and nature of the change. A teammate reviewing the commit history would immediately understand that this involves improvements to styled input and button group implementations.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch alexcarpenter/improve-input-with-button-styling

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 76ac49d and 5f7cd4b.

📒 Files selected for processing (3)

• .changeset/full-hounds-find.md (1 hunks)
• packages/clerk-js/src/ui/components/ApiKeys/ApiKeysTable.tsx (2 hunks)
• packages/clerk-js/src/ui/elements/PasswordInput.tsx (3 hunks)

🧰 Additional context used

📓 Path-based instructions (10)

.changeset/**

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Automated releases must use Changesets.

Files:

• .changeset/full-hounds-find.md

packages/clerk-js/src/ui/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/clerk-js-ui.mdc)

packages/clerk-js/src/ui/**/*.{ts,tsx}: Element descriptors should always be camelCase
Use element descriptors in UI components to enable consistent theming and styling via appearance.elements
Element descriptors should generate unique, stable CSS classes for theming
Element descriptors should handle state classes (e.g., cl-loading, cl-active, cl-error, cl-open) automatically based on component state
Do not render hard-coded values; all user-facing strings must be localized using provided localization methods
Use the useLocalizations hook and localizationKeys utility for all text and error messages
Use the styled system (sx prop, theme tokens, responsive values) for custom component styling
Use useCardState for card-level state, useFormState for form-level state, and useLoadingStatus for loading states
Always use handleError utility for API errors and use translateError for localized error messages
Use useFormControl for form field state, implement proper validation, and handle loading and error states in forms
Use localization keys for all form labels and placeholders
Use element descriptors for consistent styling and follow the theme token system
Use the Card and FormContainer patterns for consistent UI structure

Files:

• packages/clerk-js/src/ui/components/ApiKeys/ApiKeysTable.tsx
• packages/clerk-js/src/ui/elements/PasswordInput.tsx

**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

**/*.{js,jsx,ts,tsx}: All code must pass ESLint checks with the project's configuration
Follow established naming conventions (PascalCase for components, camelCase for variables)
Maintain comprehensive JSDoc comments for public APIs
Use dynamic imports for optional features
All public APIs must be documented with JSDoc
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Profile and optimize critical paths
Validate all inputs and sanitize outputs
Implement proper logging with different levels

Files:

• packages/clerk-js/src/ui/components/ApiKeys/ApiKeysTable.tsx
• packages/clerk-js/src/ui/elements/PasswordInput.tsx

**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

• packages/clerk-js/src/ui/components/ApiKeys/ApiKeysTable.tsx
• packages/clerk-js/src/ui/elements/PasswordInput.tsx

packages/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

TypeScript is required for all packages

Files:

• packages/clerk-js/src/ui/components/ApiKeys/ApiKeysTable.tsx
• packages/clerk-js/src/ui/elements/PasswordInput.tsx

packages/**/*.{ts,tsx,d.ts}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Packages should export TypeScript types alongside runtime code

Files:

• packages/clerk-js/src/ui/components/ApiKeys/ApiKeysTable.tsx
• packages/clerk-js/src/ui/elements/PasswordInput.tsx

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use proper TypeScript error types

**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoid any type - prefer unknown when type is uncertain, then narrow with type guards
Use interface for object shapes that might be extended
Use type for unions, primitives, and computed types
Prefer readonly properties for immutable data structures
Use private for internal implementation details
Use protected for inheritance hierarchies
Use public explicitly for clarity in public APIs
Prefer readonly for properties that shouldn't change after construction
Prefer composition and interfaces over deep inheritance chains
Use mixins for shared behavior across unrelated classes
Implement dependency injection for loose coupling
Let TypeScript infer when types are obvious
Use const assertions for literal types: as const
Use satisfies operator for type checking without widening
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Use type-only imports: import type { ... } from ...
No any types without justification
Proper error handling with typed errors
Consistent use of readonly for immutable data
Proper generic constraints
No unused type parameters
Proper use of utility types instead of manual type construction
Type-only imports where possible
Proper tree-shaking friendly exports
No circular dependencies
Efficient type computations (avoid deep recursion)

Files:

• packages/clerk-js/src/ui/components/ApiKeys/ApiKeysTable.tsx
• packages/clerk-js/src/ui/elements/PasswordInput.tsx

**/*.{jsx,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

**/*.{jsx,tsx}: Use error boundaries in React components
Minimize re-renders in React components

**/*.{jsx,tsx}: Always use functional components with hooks instead of class components
Follow PascalCase naming for components: UserProfile, NavigationMenu
Keep components focused on a single responsibility - split large components
Limit component size to 150-200 lines; extract logic into custom hooks
Use composition over inheritance - prefer smaller, composable components
Export components as named exports for better tree-shaking
One component per file with matching filename and component name
Use useState for simple state management
Use useReducer for complex state logic
Implement proper state initialization
Use proper state updates with callbacks
Implement proper state cleanup
Use Context API for theme/authentication
Implement proper state selectors
Use proper state normalization
Implement proper state persistence
Use React.memo for expensive components
Implement proper useCallback for handlers
Use proper useMemo for expensive computations
Implement proper virtualization for lists
Use proper code splitting with React.lazy
Implement proper cleanup in useEffect
Use proper refs for DOM access
Implement proper event listener cleanup
Use proper abort controllers for fetch
Implement proper subscription cleanup
Use proper HTML elements
Implement proper ARIA attributes
Use proper heading hierarchy
Implement proper form labels
Use proper button types
Implement proper focus management
Use proper keyboard shortcuts
Implement proper tab order
Use proper skip links
Implement proper focus traps
Implement proper error boundaries
Use proper error logging
Implement proper error recovery
Use proper error messages
Implement proper error fallbacks
Use proper form validation
Implement proper error states
Use proper error messages
Implement proper form submission
Use proper form reset
Use proper component naming
Implement proper file naming
Use proper prop naming
Implement proper...

Files:

• packages/clerk-js/src/ui/components/ApiKeys/ApiKeysTable.tsx
• packages/clerk-js/src/ui/elements/PasswordInput.tsx

**/*.{js,ts,tsx,jsx}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Support multiple Clerk environment variables (CLERK_, NEXT_PUBLIC_CLERK_, etc.) for configuration.

Files:

• packages/clerk-js/src/ui/components/ApiKeys/ApiKeysTable.tsx
• packages/clerk-js/src/ui/elements/PasswordInput.tsx

**/*.tsx

📄 CodeRabbit inference engine (.cursor/rules/react.mdc)

**/*.tsx: Use proper type definitions for props and state
Leverage TypeScript's type inference where possible
Use proper event types for handlers
Implement proper generic types for reusable components
Use proper type guards for conditional rendering

Files:

• packages/clerk-js/src/ui/components/ApiKeys/ApiKeysTable.tsx
• packages/clerk-js/src/ui/elements/PasswordInput.tsx

🧬 Code graph analysis (1)

packages/clerk-js/src/ui/components/ApiKeys/ApiKeysTable.tsx (1)

packages/clerk-js/src/ui/customizables/index.ts (1)

• Input (34-34)

🔇 Additional comments (10)

.changeset/full-hounds-find.md (1)

1-8: LGTM! Changeset accurately documents the refactoring.

The changeset correctly identifies this as a patch release and clearly describes the UI improvements: styling enhancements, increased touch area, and removal of absolute positioning.

packages/clerk-js/src/ui/elements/PasswordInput.tsx (5)

10-10: LGTM! Import supports the new border variant styling pattern.

The common import provides the borderVariants utility used in the container's dynamic styling.

---

83-88: LGTM! Container-level border styling improves the component structure.

The refactoring moves border and focus styling to the container level using common.borderVariants, which correctly handles both the normal and error states. The focus-within pseudo-class ensures the container shows focus state when either the input or button receives focus, improving the visual feedback.

---

106-106: LGTM! Unstyled input variant aligns with container-based styling.

Since the container now handles all border and focus styling via borderVariants, the input correctly uses the unstyled variant to avoid duplicate borders.

---

114-115: LGTM! IconButton props support the new focus management pattern.

Setting focusRing={false} prevents duplicate focus indicators since the container handles focus styling via focus-within. The hoverAsFocus prop provides consistent visual feedback on hover.

---

117-123: LGTM! Border radius calculations create seamless input-button integration.

The border radius styling correctly:

• Sets left corners to 0 for flush alignment with the input
• Calculates right corners by subtracting the border width from the theme radius, ensuring visual consistency
• Uses logical properties (Start/End) for proper RTL support

packages/clerk-js/src/ui/components/ApiKeys/ApiKeysTable.tsx (4)

24-24: LGTM! IconButton import supports the refactored toggle button.

The import is correctly added to support replacing the positioned Button with an inline IconButton.

---

72-77: LGTM! Container styling pattern is consistent with PasswordInput.

The borderVariants styling correctly omits the hasError parameter since this is a read-only display field rather than a validated form input. The focus-within pattern maintains consistency with the PasswordInput refactoring.

---

83-83: LGTM! Unstyled variant aligns with the container-based styling pattern.

Consistent with the PasswordInput changes, the unstyled variant removes default input styling since the container handles all border and focus states.

---

85-100: LGTM! IconButton implementation is consistent and well-structured.

The refactored IconButton correctly:

• Uses a functional updater (setRevealed(s => !s)) for state updates
• Provides dynamic aria-label reflecting the current state
• Applies the same styling pattern as PasswordInput (focusRing, hoverAsFocus, border radius calculations)
• Uses the icon prop to dynamically render Eye/EyeSlash based on reveal state

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}