Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/green-hotels-study.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/localizations': patch
---

fix(localizations): add missing Hungarian translations for form placeholders and legal consent
19 changes: 10 additions & 9 deletions packages/localizations/src/hu-HU.ts
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export const huHU: LocalizationResource = {
anyNumbers: undefined,
cardNumber: undefined,
cvcZip: undefined,
developmentMode: undefined,
developmentMode: 'Fejlesztői mód',
expirationDate: undefined,
testCardInfo: undefined,
},
Expand Down Expand Up @@ -212,11 +212,11 @@ export const huHU: LocalizationResource = {
formFieldInputPlaceholder__apiKeyName: undefined,
formFieldInputPlaceholder__backupCode: undefined,
formFieldInputPlaceholder__confirmDeletionUserAccount: 'Fiók törlése',
formFieldInputPlaceholder__emailAddress: undefined,
formFieldInputPlaceholder__emailAddress: 'Add meg az e-mail címedet',
formFieldInputPlaceholder__emailAddress_username: undefined,
formFieldInputPlaceholder__emailAddresses: 'pelda@email.hu, pelda2@email.hu',
formFieldInputPlaceholder__firstName: undefined,
formFieldInputPlaceholder__lastName: undefined,
formFieldInputPlaceholder__firstName: 'Keresztnév',
formFieldInputPlaceholder__lastName: 'Vezetéknév',
formFieldInputPlaceholder__organizationDomain: undefined,
formFieldInputPlaceholder__organizationDomainEmailAddress: undefined,
formFieldInputPlaceholder__organizationName: undefined,
Expand Down Expand Up @@ -808,13 +808,14 @@ export const huHU: LocalizationResource = {
},
legalConsent: {
checkbox: {
label__onlyPrivacyPolicy: undefined,
label__onlyTermsOfService: undefined,
label__termsOfServiceAndPrivacyPolicy: undefined,
label__onlyPrivacyPolicy: 'Elfogadom az {{ privacyPolicyLink || link("Adatkezelési Tájékoztatót") }}',
label__onlyTermsOfService: 'Elfogadom az {{ termsOfServiceLink || link("Általános Szerződési Feltételeket") }}',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know Hungarian, but I see that in our existing localization for the Clerk terms of service in the footer, we use "Felhasználási feltételek" which seems slightly different. Which do you think is best?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dmoerner,

Thank you for pointing out the existing translations.

In the footer, compactness is key, so the current "Felhasználási feltételek" works well given the space constraints. However, for the sign-up page, legal accuracy is the primary consideration. "Általános Szerződési Feltételek" (ÁSZF) is the standard Hungarian legal terminology, and since there is more space available there, I would prefer the version in this PR.

While I didn't initially account for every use case, I believe this distinction between the footer and the registration flow is the most professional approach. What do you think?

label__termsOfServiceAndPrivacyPolicy:
'Elfogadom az {{ termsOfServiceLink || link("Általános Szerződési Feltételeket") }} és az {{ privacyPolicyLink || link("Adatkezelési Tájékoztatót") }}',
},
continue: {
subtitle: undefined,
title: undefined,
subtitle: 'A folytatáshoz kérlek, olvasd el és fogadd el a feltételeket',
title: 'Jogi nyilatkozat',
},
},
phoneCode: {
Expand Down
Loading