-
Notifications
You must be signed in to change notification settings - Fork 440
fix(localizations): add placeholders for email, name fields and legal consent in hu-HU #8080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tornaia
wants to merge
5
commits into
clerk:main
Choose a base branch
from
tornaia:fix/email-and-name-placeholders-and-legal-consent-hu-hu
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c8399b7
fix(localizations): add placeholders for email, name fields and legal…
tornaia 0e7d646
Merge branch 'main' into fix/email-and-name-placeholders-and-legal-co…
tornaia 8f3efb0
Merge branch 'main' into fix/email-and-name-placeholders-and-legal-co…
tornaia 2bd93e9
Merge branch 'main' into fix/email-and-name-placeholders-and-legal-co…
tornaia cc30d10
Merge branch 'main' into fix/email-and-name-placeholders-and-legal-co…
tornaia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@clerk/localizations': patch | ||
| --- | ||
|
|
||
| fix(localizations): add missing Hungarian translations for form placeholders and legal consent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not know Hungarian, but I see that in our existing localization for the Clerk terms of service in the footer, we use "Felhasználási feltételek" which seems slightly different. Which do you think is best?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dmoerner,
Thank you for pointing out the existing translations.
In the footer, compactness is key, so the current "Felhasználási feltételek" works well given the space constraints. However, for the sign-up page, legal accuracy is the primary consideration. "Általános Szerződési Feltételek" (ÁSZF) is the standard Hungarian legal terminology, and since there is more space available there, I would prefer the version in this PR.
While I didn't initially account for every use case, I believe this distinction between the footer and the registration flow is the most professional approach. What do you think?