fix(clerk-js): Fix token cache refresh timer leak#8098
Open
jacekradko wants to merge 8 commits intomainfrom
Open
fix(clerk-js): Fix token cache refresh timer leak#8098jacekradko wants to merge 8 commits intomainfrom
jacekradko wants to merge 8 commits intomainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionTokenCachethat caused token refresh requests to fire much earlier than expectedset()is called multiple times for the same cache key (from_updateClienthydration AND#refreshTokenInBackground), old timers were never cleared — each leaked timer independently firedonRefresh, accelerating the effective polling ratesetInternalbefore creating the new cache entrysession.touch()or any API response that triggers_updateClientTest plan
session.touch()Summary by CodeRabbit
Bug Fixes
Tests