fix(expo): add appleSignIn option to config plugin to allow opting out#8113
fix(expo): add appleSignIn option to config plugin to allow opting out#8113chriscanin wants to merge 1 commit intomainfrom
Conversation
…t of Apple Sign In entitlement
🦋 Changeset detectedLatest commit: c7f4e21 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe pull request introduces an 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
brkalow
left a comment
There was a problem hiding this comment.
It feels odd that this defaults to true, but I understand the backwards compat point.
Summary
Fixes #8050
The
withClerkExpoconfig plugin was unconditionally adding thecom.apple.developer.applesigninentitlement to every app, even those that don't use Apple Sign In. This caused issues for apps that intentionally don't include Apple Sign In (e.g., apps targeting non-Apple platforms or apps that want to manage entitlements manually).Change: Added an
appleSignInoption to the plugin props that defaults totruefor full backwards compatibility. Apps can opt out by passingappleSignIn: false.Usage:
Test plan
appleSignInoption) still get the entitlement added (backwards compat)appleSignIn: falseprevents the entitlement from being addedappleSignIn: trueexplicitly still adds the entitlement🤖 Generated with Claude Code
Summary by CodeRabbit