Adding an option to override the default SpecRunner template file#66
Open
davyboyhayes wants to merge 2 commits intocloudchen:masterfrom
Open
Adding an option to override the default SpecRunner template file#66davyboyhayes wants to merge 2 commits intocloudchen:masterfrom
davyboyhayes wants to merge 2 commits intocloudchen:masterfrom
Conversation
|
I've run into exactly the same issue, but I solved it by adding a I can issue a PR if interested. |
|
I know this is an old request but it gets another vote from me. |
Pulling latest from cloudchen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had an issue whereby the requirejs code at the bottom of the outputted _SpecRunner.html file was including all of the jasmine.src files, that we actually didn't need to be included in the SpecRunner file, but we needed to specify them because https://github.com/maenu/grunt-template-jasmine-istanbul#templateoptionsfiles doesn't appear to instrument any of these files, only the ones in jasmine.src.
One bug aside, I can see use cases where users may want to customize their SpecRunner.html file