Conversation
This switches impyla to depend on `winkerberos` on windows rather than `kerberos`. The `winkerberos` package provides pre-built wheels for `windows` with the same python-facing API.
jcrist
force-pushed
the
use-winkerberos-on-windows
branch
from
a078a86 to
4bd7592
Compare
|
Thanks for working on this! I have concerns about testing though: I don't know whether anyone tests Impyla with Windows + Kerberos, so it seems possible to break some use cases without noticing it. All the test environments I know about are Linux based. |
There are not, and I also have no way to test this. I've had similar code in place for years in another kerberos-related project though with no complaints, but this may just mean that no one is using it on windows :). This PR was quick to work up, no pressure at all to merge it. Apologies that I can't be more help here ensuring this is correct. |
|
I started asking around about Impyla + Windows + Kerberos inside Cloudera. I was thinking about an alternative in case switching to winkerberos from kerberos would be problematic for some people:
This way an easy installation could be provided on Windows without the chance of breaking any existing use cases. |
I didn't get any feedback yet about this setup. @jcrist Is it ok for you to proceed this way? |
Based on another PR: cloudera#504
|
@csringhofer @jcrist Hi there! We are in need of this Patch for our internal setup (which only works with winkerberos). Can we help you with testing? |
Winkerberos is an alternative to kerberos package on Windows and has the same api, so can be used as a drop in replacement. Based on another PR: cloudera#504 The difference is that the current patch prefers kerberos if both are available to avoid the breaking existing worklflows. setup.py is also not modified. To use winkerberos it has to be installed independently from impyla and impyla should be installed without [kerberos] extra.
Winkerberos is an alternative to kerberos package on Windows and has the same api, so can be used as a drop in replacement. Based on another PR: cloudera#504 The difference is that the current patch prefers kerberos if both are available to avoid the breaking existing worklflows. setup.py is also not modified. To use winkerberos it has to be installed independently from impyla and impyla should be installed without [kerberos] extra.
Winkerberos is an alternative to kerberos package on Windows and has the same api, so can be used as a drop in replacement. Based on another PR: cloudera#504 The difference is that the current patch prefers kerberos if both are available to avoid the breaking existing workflows. setup.py is also not modified. To use winkerberos it has to be installed independently from impyla and impyla should be installed without [kerberos] extra.
Winkerberos is an alternative to kerberos package on Windows and has the same api, so can be used as a drop in replacement. Based on another PR: cloudera#504 The difference is that the current patch prefers kerberos if both are available to avoid the breaking existing workflows. setup.py is also not modified. To use winkerberos it has to be installed independently from impyla and impyla should be installed without [kerberos] extra.
Winkerberos is an alternative to kerberos package on Windows and has the same api, so can be used as a drop in replacement. Based on another PR: #504 The difference is that the current patch prefers kerberos if both are available to avoid the breaking existing workflows. setup.py is also not modified. To use winkerberos it has to be installed independently from impyla and impyla should be installed without [kerberos] extra.
3 participants
This switches impyla to depend on
winkerberoson windows rather thankerberos. Thewinkerberospackage provides pre-built wheels forwindowswith the same python-facing API.Fixes #466.