Skip to content

Proposal for improving types in query method #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmorrell wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Proposal for improving types in query method #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 6 additions & 15 deletions packages/storage/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,23 +152,14 @@ export class Storage {
* @param opts - Options containing the SQL query, parameters, and result format preference
* @returns Promise resolving to either raw query results or formatted array
*/
private async query(sql: string, params?: unknown[], isRaw?: boolean) {
private async query<T = Record<string, string | number | boolean | null>>(
sql: string, params?: unknown[]
) {
// Now proceed with executing the query
const cursor = await this.executeRawQuery({ sql, params })
if (!cursor) return []

if (isRaw) {
return {
columns: cursor.columnNames,
rows: Array.from(cursor.raw()),
meta: {
rows_read: cursor.rowsRead,
rows_written: cursor.rowsWritten,
},
}
}
const cursor = await this.executeRawQuery({ sql, params });
if (!cursor) return [] as T[];

return cursor.toArray()
return cursor.toArray() as T[];
}

async runMigrations() {
Expand Down