-
Notifications
You must be signed in to change notification settings - Fork 306
add task management system with lifecycle tracking #683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
commit: |
Claude Code ReviewSummary: Well-architected task system with solid lifecycle tracking. A few substantive issues to address. Issues Found1. Race Condition in Task Abort Controller Cleanup (packages/agents/src/task.ts:888-890) 2. Missing Workflow Tests
3. Retry Logic Issue in 4. Task Deadline Cache Never Invalidated on Timeout Update (packages/agents/src/task.ts:344) 5. Incomplete Validation in
6. SQL Injection Protection (packages/agents/src/task.ts:810-838) Minor Observations
RecommendationAddress issues #1, #2, #5, and #6 before merging. Issues #3 and #4 are lower priority but should be tracked. |
This syncs documentation from cloudflare/agents PR #683 which adds a task management system with lifecycle tracking to the Agents SDK. Changes include: - New concept page explaining tasks and their lifecycle - API reference documentation for the Tasks API - Tutorial guide for building a task-based agent - Examples of using @task() decorator and TaskContext - Client-side task tracking with useTask() hook Related PR: cloudflare/agents#683
adds a task system to the agents sdk so we can run long operations with proper tracking and updates. includes a @task() decorator, workflow support, a unified client api for real-time status, and server-side task management. tasks are persisted, can be canceled, and stream progress and events over websockets