Skip to content

Conversation

@SirCortly
Copy link
Collaborator

@SirCortly SirCortly commented Dec 4, 2025

This is a fairly large, complex migration. Migration is mostly complete, the main thing left is fixing up a few patterns of drift in the e2e tests.

If you revert 9ccbb50, all tests are passing. This commit is WIP to resolve V4 empty value defaults to V5 null value default transformations. The integration tests are currently failing and need further investigation. My hunch is that either 1) The config context is not being passed into the state transformations during the integration test or 2) There is an issue with the deeply nested structures in this integration affecting the default value transformations

Including the default value drift described above, the following drift remains:

1. http_only_cookie_attribute Drift (19 resources)                                                                                                        
  - v4 behavior: Sets value to null (removed from state)                                                                                                    
  - v5 behavior: Changes from false → true                                                                                                                  
  - Impact: All self-hosted and SSH apps show this drift                                                                                                    
  - Why: v4 provider appears to remove this attribute when not explicitly set, but v5 expects it to be true by default                                      
                                                                                                                                                            
  2. Empty/Default Value Removal (all resources)                                                                                                            
  - Fields being removed (set to null) when they have empty/default values:                                                                                 
    - allowed_idps = []                                                                                                                                     
    - auto_redirect_to_identity = false                                                                                                                     
    - enable_binding_cookie = false                                                                                                                         
    - options_preflight_bypass = false                                                                                                                      
    - service_auth_401_redirect = false                                                                                                                     
    - skip_interstitial = false                                                                                                                             
    - tags = []                                                                                                                                             
                                                                                                                                                            
  3. SAAS App-specific Issues:                                                                                                                              
  - saas_oidc: scopes array order changed from ["openid", "profile", "email"] to ["openid", "email", "profile"]                                             
  - custom_claims: Empty name_by_idp = {} being removed (set to null)     

@SirCortly SirCortly changed the title (Phase 2) WIP: v4->v5 zero_trust_access_application (Phase 0) WIP: v4->v5 zero_trust_access_application Dec 19, 2025
@SirCortly SirCortly force-pushed the cortlyons/v4-to-v5-cloudflare_zero_trust_access_applications branch 7 times, most recently from c8d2cd9 to 3950ce2 Compare December 23, 2025 21:03
# Conflicts:
#	integration/v4_to_v5/integration_test.go
#	internal/registry/registry.go
@SirCortly SirCortly force-pushed the cortlyons/v4-to-v5-cloudflare_zero_trust_access_applications branch from 3950ce2 to adcadbd Compare December 23, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant