Skip to content

fix(vite-8): remove deprecated Rollup config options for Vite 8/Rolldown #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yunus25jmi1 wants to merge 13 commits into
base: main
Choose a base branch
from
Open

fix(vite-8): remove deprecated Rollup config options for Vite 8/Rolldown #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3fb524c
fix(vite-8): remove deprecated Rollup config options for Vite 8/Rolldown
yunus25jmi1 Mar 15, 2026
109ac93
fix: address bonk review comments
yunus25jmi1 Mar 15, 2026
6beaa47
fix(vite-8): use rolldownOptions for Vite 8+ treeshake config
yunus25jmi1 Mar 15, 2026
1e6744e
fix: address bonk review comments for Vite 8/Rolldown
yunus25jmi1 Mar 22, 2026
029d279
fix: resolve merge conflict and apply robust onwarn logic
yunus25jmi1 Mar 22, 2026
6b9d5ef
fix: apply final conflict resolutions and formatting for Vite 8
yunus25jmi1 Mar 22, 2026
45cd355
fix: resolve import conflict and formatting
yunus25jmi1 Mar 22, 2026
719778e
fix: resolve duplicate import conflict
yunus25jmi1 Mar 22, 2026
bec552d
fix: remove duplicate createDirectiveOnwarn declaration
yunus25jmi1 Mar 22, 2026
89c24ea
fix: update tests for Vite 8 version-gated config
yunus25jmi1 Mar 23, 2026
f0e3905
fix: consolidate getClientBuildOptions functions and fix type cast
yunus25jmi1 Mar 23, 2026
701a42d
test: add Vite 8 multi-env build config test (Issue 5)
yunus25jmi1 Mar 23, 2026
10bd03c
Merge upstream/main into fix/vite-8-warnings-clean
yunus25jmi1 Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions packages/vinext/src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* needed for most Next.js apps.
*/

import vinext, { clientOutputConfig, clientTreeshakeConfig } from "./index.js";
import vinext, { getClientBuildOptions, getViteMajorVersion } from "./index.js";
import { printBuildReport } from "./build/report.js";
import { runPrerender } from "./build/run-prerender.js";
import path from "node:path";
Expand Down Expand Up @@ -362,6 +362,7 @@ async function buildApp() {
console.log(`\n vinext build (Vite ${getViteVersion()})\n`);

const isApp = hasAppDir();
const viteMajorVersion = getViteMajorVersion();
// In verbose mode, skip the custom logger so raw Vite/Rollup output is shown.
const logger = parsed.verbose
? vite.createLogger("info", { allowClearScreen: false })
Expand Down Expand Up @@ -465,11 +466,9 @@ async function buildApp() {
outDir: "dist/client",
manifest: true,
ssrManifest: true,
rollupOptions: {
input: "virtual:vinext-client-entry",
output: clientOutputConfig,
treeshake: clientTreeshakeConfig,
},
...getClientBuildOptions(viteMajorVersion, {
index: "virtual:vinext-client-entry",
}),
},
},
logger,
Expand Down
Loading
Loading