upgrade dependencies #202
Draft
upgrade dependencies #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpichler
force-pushed
the
alpichler/gradle93
branch
2 times, most recently
from
de0b6a5 to
85bea1e
Compare
alpichler
commented
Jan 23, 2026
| dependencies { | ||
| testImplementation("org.junit.jupiter:junit-jupiter-api:5.8.1") | ||
| testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine:5.8.1") | ||
| testRuntimeOnly("org.junit.platform:junit-platform-launcher:1.8.1") |
Author
There was a problem hiding this comment.
consumers of the plugin using JUnit Platform will need to add this
alpichler
commented
Jan 23, 2026
Comment on lines
37
to
42
| } | ||
|
|
||
| // Workaround for https://github.com/n0mer/gradle-git-properties/issues/260 | ||
| // The plugin crashes on Gradle 9 | ||
| tasks.withType(com.gorylenko.GenerateGitPropertiesTask).configureEach { | ||
| enabled = false |
Author
There was a problem hiding this comment.
TODO: remove this once the issue is resolved
alpichler
commented
Jan 23, 2026
Comment on lines
+57
to
+62
| // TODO: remove when upgrading io.cloudflight.autoconfigure-settings in settings.gradle.kts | ||
| // io.cloudflight.autoconfigure-settings 1.2.0 pulls in kotlin gradle plugin 2.1.20 | ||
| // this breaks the build as it depends on features only available up to gradle 8.13 | ||
| implementation(libs.kotlin.gradleplugin) | ||
|
|
alpichler
force-pushed
the
alpichler/gradle93
branch
from
85bea1e to
287c3d5
Compare
alpichler
commented
Jan 23, 2026
Comment on lines
+22
to
+28
|
|
||
| /** | ||
| * Monkey-patched ModelModifier to use JavaType in resolve() call instead of Type. | ||
| * In groovy 3, type is automatically converted, but in groovy 4 (from gradle 9.0+) it is not. | ||
| * TODO: Remove this when https://github.com/gigaSproule/swagger-gradle-plugin/issues/186 is fixed. | ||
| */ | ||
| class ModelModifier extends ModelResolver { |
Author
There was a problem hiding this comment.
we should really avoid this, but the only other solution i can think of is replacing com.benjaminsproule:swagger-gradle-plugin and gradle.plugin.org.hidetake:gradle-swagger-generator-plugin with other plugins that are still being maintained.
Author
There was a problem hiding this comment.
replacement suggestions:
gradle.plugin.org.hidetake:gradle-swagger-generator-plugin => https://github.com/OpenAPITools/openapi-generator/tree/master
com.benjaminsproule:swagger-gradle-plugin => https://github.com/springdoc/springdoc-openapi-gradle-plugin
alpichler
force-pushed
the
alpichler/gradle93
branch
2 times, most recently
from
4bd2336 to
d171573
Compare
alpichler
force-pushed
the
alpichler/gradle93
branch
from
d171573 to
5129502
Compare
Signed-off-by: Alex Pichler <alex.pichler@cloudflight.io>
alpichler
force-pushed
the
alpichler/gradle93
branch
from
5129502 to
edf7091
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on cloudflightio/license-gradle-plugin#32
Upgrade Gradle to 9.3.0
Upgrade Kotlin & KGP to 2.3.0 (no longer supports versions <1.9)
Upgrade Publish Gradle Plugin to 2.0.0