This repository was archived by the owner on Jan 21, 2022. It is now read-only.
vagrant aws: adding associate public ip functionality#132
Open
MalteJ wants to merge 2 commits intocloudfoundry-attic:masterfrom
Open
vagrant aws: adding associate public ip functionality#132MalteJ wants to merge 2 commits intocloudfoundry-attic:masterfrom
MalteJ wants to merge 2 commits intocloudfoundry-attic:masterfrom
Conversation
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/74050214. |
|
@goehmen this looks reasonable. What does the bosh team think? |
Author
|
There was a mistake in evaluating the new environment variable. I have fixed this in 1ad14f9. |
bosh-ci-push-pull
force-pushed
the
master
branch
4 times, most recently
from
2269213 to
e28e7e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added an environment variable "BOSH_LITE_ASSOCIATE_PUBLIC_IP" which defines wether to associate a public ip to a VPC instance or not. Further the private/public ip output is adjusted.