This repository was archived by the owner on Jan 21, 2022. It is now read-only.
Revert "Update resolv.conf to use 8.8.8.8"#348
Open
giner wants to merge 1 commit intocloudfoundry-attic:masterfrom
Open
Revert "Update resolv.conf to use 8.8.8.8"#348giner wants to merge 1 commit intocloudfoundry-attic:masterfrom
giner wants to merge 1 commit intocloudfoundry-attic:masterfrom
Conversation
DNS configuration should not be hard-coded. This causes issues for those who have external DNS blocked for any reasons. This reverts commit d984f8c. Conflicts: packer/scripts/update-resolv.conf.sh templates/vmware.json
|
Hey giner! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
Contributor
|
I would still prefer to have an env variable to opt out since majority of bosh-lite envs have internet access (almost all CF teams use bosh-lite for testing). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DNS configuration should not be hard-coded. This causes issues for those who have external DNS blocked for any reasons. Blocking external DNS is very common for private networks.
Another related PR: #345