feat(app): add lifecycle parameter with CNB support #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add lifecycle parameter to app resource/datasource and diego_cnb feature flag. Supports 'buildpack', 'docker', and 'cnb' with validation and tests. BREAKING CHANGE: lifecycle changes force app recreation
gmllt
force-pushed
the
add-cnb-lifecycle
branch
from
9cac9fc to
8885cfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds "lifecycle" parameter with CNB support.
Add 'lifecycle' parameter to app resource allowing 'buildpack', 'docker', or 'cnb' (Cloud Native Buildpacks) values. Also add 'diego_cnb' feature flag to enable CNB support in Cloud Foundry.
BREAKING CHANGE: Changing lifecycle parameter forces app recreation