-
Notifications
You must be signed in to change notification settings - Fork 322
Feature: handle rate limiting of UAA server. Fixes #1307 #1332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Lokowandtg
wants to merge
3
commits into
cloudfoundry:main
Choose a base branch
from
Lokowandtg:uaa_ratelimit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
cloudfoundry-client-reactor/src/main/java/org/cloudfoundry/reactor/uaa/ReactorRatelimit.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| /* | ||
| * Copyright 2013-2025 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.cloudfoundry.reactor.uaa; | ||
|
|
||
| import java.util.Map; | ||
| import org.cloudfoundry.reactor.ConnectionContext; | ||
| import org.cloudfoundry.reactor.TokenProvider; | ||
| import org.cloudfoundry.uaa.ratelimit.Ratelimit; | ||
| import org.cloudfoundry.uaa.ratelimit.RatelimitRequest; | ||
| import org.cloudfoundry.uaa.ratelimit.RatelimitResponse; | ||
| import reactor.core.publisher.Mono; | ||
|
|
||
| public final class ReactorRatelimit extends AbstractUaaOperations implements Ratelimit { | ||
|
|
||
| /** | ||
| * Creates an instance | ||
| * | ||
| * @param connectionContext the {@link ConnectionContext} to use when communicating with the server | ||
| * @param root the root URI of the server. Typically something like {@code https://uaa.run.pivotal.io}. | ||
| * @param tokenProvider the {@link TokenProvider} to use when communicating with the server | ||
| * @param requestTags map with custom http headers which will be added to web request | ||
| */ | ||
| public ReactorRatelimit( | ||
| ConnectionContext connectionContext, | ||
| Mono<String> root, | ||
| TokenProvider tokenProvider, | ||
| Map<String, String> requestTags) { | ||
| super(connectionContext, root, tokenProvider, requestTags); | ||
| } | ||
|
|
||
| @Override | ||
| public Mono<RatelimitResponse> getRatelimit(RatelimitRequest request) { | ||
| return get( | ||
| request, | ||
| RatelimitResponse.class, | ||
| builder -> builder.pathSegment("RateLimitingStatus")) | ||
| .checkpoint(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
cloudfoundry-client/src/main/java/org/cloudfoundry/uaa/ratelimit/Ratelimit.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| /* | ||
| * Copyright 2013-2025 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.cloudfoundry.uaa.ratelimit; | ||
|
|
||
| import reactor.core.publisher.Mono; | ||
|
|
||
| /** | ||
| * Main entry point to the UAA Ratelimit Client API | ||
| */ | ||
| public interface Ratelimit { | ||
|
|
||
| Mono<RatelimitResponse> getRatelimit(RatelimitRequest request); | ||
| } |
63 changes: 63 additions & 0 deletions
63
cloudfoundry-client/src/main/java/org/cloudfoundry/uaa/ratelimit/_Current.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| /* | ||
| * Copyright 2013-2025 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.cloudfoundry.uaa.ratelimit; | ||
|
|
||
|
|
||
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
| import com.fasterxml.jackson.databind.annotation.JsonDeserialize; | ||
|
|
||
| import java.util.Date; | ||
|
|
||
| import org.immutables.value.Value; | ||
|
|
||
| /** | ||
| * The payload for the uaa ratelimiting | ||
| */ | ||
| @JsonDeserialize | ||
| @Value.Immutable | ||
| abstract class _Current { | ||
|
|
||
| /** | ||
| * The number of configured limiter mappings | ||
| */ | ||
| @JsonProperty("limiterMappings") | ||
| abstract Integer getLimiterMappings(); | ||
|
|
||
| /** | ||
| * Is ratelimit "ACTIVE" or not? Possible values are DISABLED, PENDING, ACTIVE | ||
| */ | ||
| @JsonProperty("status") | ||
| abstract String getStatus(); | ||
|
|
||
| /** | ||
| * Timestamp, when this Current was created. | ||
| */ | ||
| @JsonProperty("asOf") | ||
| abstract Date getTimeOfCurrent(); | ||
|
|
||
| /** | ||
| * The credentialIdExtractor | ||
| */ | ||
| @JsonProperty("credentialIdExtractor") | ||
| abstract String getCredentialIdExtractor(); | ||
|
|
||
| /** | ||
| * The loggingLevel. Valid values include: "OnlyLimited", "AllCalls" and "AllCallsWithDetails" | ||
| */ | ||
| @JsonProperty("loggingLevel") | ||
| abstract String getLoggingLevel(); | ||
| } |
24 changes: 24 additions & 0 deletions
24
cloudfoundry-client/src/main/java/org/cloudfoundry/uaa/ratelimit/_RatelimitRequest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| /* | ||
| * Copyright 2013-2025 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.cloudfoundry.uaa.ratelimit; | ||
|
|
||
| import org.immutables.value.Value; | ||
|
|
||
| @Value.Immutable | ||
| abstract class _RatelimitRequest { | ||
|
|
||
| } |
36 changes: 36 additions & 0 deletions
36
cloudfoundry-client/src/main/java/org/cloudfoundry/uaa/ratelimit/_RatelimitResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /* | ||
| * Copyright 2013-2025 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.cloudfoundry.uaa.ratelimit; | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
| import com.fasterxml.jackson.databind.annotation.JsonDeserialize; | ||
| import org.cloudfoundry.Nullable; | ||
| import org.immutables.value.Value; | ||
|
|
||
| @JsonDeserialize | ||
| @Value.Immutable | ||
| abstract class _RatelimitResponse { | ||
|
|
||
| @JsonProperty("current") | ||
| @Nullable | ||
| abstract Current getCurrentData(); | ||
|
|
||
| @JsonProperty("fromSource") | ||
| @Nullable | ||
| abstract String getFromSource(); | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apply the same suggestion as the
adminUaaClientThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. Thanks!